Cmnt: [SRU][Q][PATCH 0/9] Enable PMF on AMD HPT/STX/KRK

[Tim Whisonant]

On Wed, Dec 03, 2025 at 09:52:01AM +0100, Stefan Bader wrote:
> On 03/12/2025 02:49, Tim Whisonant wrote:
> > On Tue, Dec 02, 2025 at 02:00:45PM +0800, AceLan Kao wrote:
> > > From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
> > > 
> > > BugLink: https://bugs.launchpad.net/bugs/2125022
> > > 
> > > [Impact]
> > > It is for basic AMD HPT/STX/KRK function. Current PMF driver missing two features:
> > > 1. For the thermal policy input, the AMD Fusion Sensor Hub could not pass the data to PMF driver.
> > > 2. PMF driver could not parse the thermal policy binary which is stored in the BIOS.
> > > 
> > > [Fix]
> > > Need this series of patches which is included in v6.18-rc1
> > > https://lore.kernel.org/platform-driver-x86/175758069520.12104.11266006471249026373.b4-ty@linux.intel.com/T/#t
> > > 
> > > 2ab7713d6e94 platform/x86/amd/pmf: Add debug logs for pending requests and custom BIOS inputs
> > > 62214d942d2b platform/x86/amd/pmf: Call enact function sooner to process early pending requests
> > > b21ec88340b7 platform/x86/amd/pmf: Preserve custom BIOS inputs for evaluating the policies
> > > 04199ef48ac2 platform/x86/amd/pmf: Add custom BIOS input support for AMD_CPU_ID_PS
> > > 4389d38080d7 platform/x86/amd/pmf: Add helper to verify BIOS input notifications are enable/disable
> > > 37336ecb06a8 platform/x86/amd/pmf: Update ta_pmf_action structure member
> > > ebc68a3451ce platform/x86/amd/pmf: Extend custom BIOS inputs for more policies
> > > d82e3d2dd0ba platform/x86/amd/pmf: Fix the custom bios input handling mechanism
> > > f10ea2df9e4d platform/x86/amd/pmf: Add support for adjusting PMF PPT and PPT APU thresholds
> > > 
> > > [Test]
> > > PMF driver is loaded and function works properly on AMD platforms.
> > > 
> > > [Where problems could occur]
> > > It's hard to evaluate the problems those patches may occur. Most of them
> > > are withing amd/pmf, so it only impact the amd pmf functionailties.
> > > 
> > > Shyam Sundar S K (9):
> > >    platform/x86/amd/pmf: Add support for adjusting PMF PPT and PPT APU
> > >      thresholds
> > >    platform/x86/amd/pmf: Fix the custom bios input handling mechanism
> > >    platform/x86/amd/pmf: Extend custom BIOS inputs for more policies
> > >    platform/x86/amd/pmf: Update ta_pmf_action structure member
> > >    platform/x86/amd/pmf: Add helper to verify BIOS input notifications
> > >      are enable/disable
> > >    platform/x86/amd/pmf: Add custom BIOS input support for AMD_CPU_ID_PS
> > >    platform/x86/amd/pmf: Preserve custom BIOS inputs for evaluating the
> > >      policies
> > >    platform/x86/amd/pmf: Call enact function sooner to process early
> > >      pending requests
> > >    platform/x86/amd/pmf: Add debug logs for pending requests and custom
> > >      BIOS inputs
> > > 
> > >   drivers/platform/x86/amd/pmf/acpi.c   | 87 +++++++++++++++++++++++++--
> > >   drivers/platform/x86/amd/pmf/pmf.h    | 77 +++++++++++++++++++++---
> > >   drivers/platform/x86/amd/pmf/spc.c    | 80 +++++++++++++++++++++---
> > >   drivers/platform/x86/amd/pmf/tee-if.c | 22 ++++++-
> > >   4 files changed, 240 insertions(+), 26 deletions(-)
> > > 
> > > -- 
> > > 2.43.0
> > > 
> > 
> > Hi AceLan, I noticed that the armhf build is failing here:
> > http://ktml-board.kernel/ktml/logs/1764655362.3245424_1.ktml-board,U=10222:2,.questing:linux.build_log.txt
> > 
> > Is this expected?
> 
> Hi Tim,
> 
> are those builds cdb based? Questing starts to have code which enables tools
> shipped with the kernel to be cross-compiled. But that requires a specific
> dependency resolution which I believe cdb has not implemented, yet. Not sure
> why only armhf in this case. I remember a similar log but cannot remember it
> was armhf or any non-x86 arch.
> 
> -Stefan
> 

Hi Stefan, yes I think that it is probably using CBD to build.
Thank you for the clarification. I will consider this a non-issue
for the purposes of the review.

Tim

> > 
> > Tim
> > 
>