ACK/Cmt: [SRU][N:linux-bluefield][PATCH v2 2/2] pinctrl: Constify static 'pinctrl_desc'
Thibault Ferrante
thibault.ferrante at canonical.com
Wed Aug 13 09:17:44 UTC 2025
On 12/08/2025 17:48, David Thompson wrote:
> From: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
>
> BugLink: https://bugs.launchpad.net/bugs/2119333
>
> The local static 'struct pinctrl_desc' is not modified, so can be made
> const for code safety.
>
> Acked-by: Lorenzo Bianconi <lorenzo at kernel.org>
> Acked-by: Jesper Nilsson <jesper.nilsson at axis.com>
> Reviewed-by: Charles Keepax <ckeepax at opensource.cirrus.com>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at linaro.org>
> Reviewed-by: Hal Feng <hal.feng at starfivetech.com>
> Acked-by: Emil Renner Berthing <emil.renner.berthing at canonical.com>
> Acked-by: Vladimir Zapolskiy <vz at mleia.com>
> Link: https://lore.kernel.org/20250611-pinctrl-const-desc-v2-16-b11c1d650384@linaro.org
> Signed-off-by: Linus Walleij <linus.walleij at linaro.org>
> (backported from commit 490bfd1ca556)
Please always include the full hash (40 chars).
This is not critical and can be fixed when applying.
> [davthompson: remove pinctrl-airoha.c modification as we are missing
> pinctrl: airoha: Add support for EN7581 SoC]
> Signed-off-by: David Thompson <davthompson at nvidia.com>
> ---
> drivers/pinctrl/berlin/berlin.c | 2 +-
> drivers/pinctrl/cirrus/pinctrl-cs42l43.c | 2 +-
> drivers/pinctrl/pinctrl-artpec6.c | 2 +-
> drivers/pinctrl/pinctrl-bm1880.c | 2 +-
> drivers/pinctrl/pinctrl-k210.c | 2 +-
> drivers/pinctrl/pinctrl-lpc18xx.c | 2 +-
> drivers/pinctrl/pinctrl-mlxbf3.c | 2 +-
> drivers/pinctrl/pinctrl-tb10x.c | 2 +-
> drivers/pinctrl/pinctrl-zynq.c | 2 +-
> drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c | 2 +-
> 10 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/pinctrl/berlin/berlin.c b/drivers/pinctrl/berlin/berlin.c
> index 9550cc8095c2..0127c74b9d48 100644
> --- a/drivers/pinctrl/berlin/berlin.c
> +++ b/drivers/pinctrl/berlin/berlin.c
> @@ -286,7 +286,7 @@ static int berlin_pinctrl_build_state(struct platform_device *pdev)
> return 0;
> }
>
> -static struct pinctrl_desc berlin_pctrl_desc = {
> +static const struct pinctrl_desc berlin_pctrl_desc = {
> .name = "berlin-pinctrl",
> .pctlops = &berlin_pinctrl_ops,
> .pmxops = &berlin_pinmux_ops,
> diff --git a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c
> index 012b0a3bad5a..7ff940bae4db 100644
> --- a/drivers/pinctrl/cirrus/pinctrl-cs42l43.c
> +++ b/drivers/pinctrl/cirrus/pinctrl-cs42l43.c
> @@ -448,7 +448,7 @@ static const struct pinconf_ops cs42l43_pin_conf_ops = {
> .pin_config_group_set = cs42l43_pin_config_group_set,
> };
>
> -static struct pinctrl_desc cs42l43_pin_desc = {
> +static const struct pinctrl_desc cs42l43_pin_desc = {
> .name = "cs42l43-pinctrl",
> .owner = THIS_MODULE,
>
> diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
> index dd93f124e0a0..ca450522b7ec 100644
> --- a/drivers/pinctrl/pinctrl-artpec6.c
> +++ b/drivers/pinctrl/pinctrl-artpec6.c
> @@ -907,7 +907,7 @@ static const struct pinconf_ops artpec6_pconf_ops = {
> .pin_config_group_set = artpec6_pconf_group_set,
> };
>
> -static struct pinctrl_desc artpec6_desc = {
> +static const struct pinctrl_desc artpec6_desc = {
> .name = "artpec6-pinctrl",
> .owner = THIS_MODULE,
> .pins = artpec6_pins,
> diff --git a/drivers/pinctrl/pinctrl-bm1880.c b/drivers/pinctrl/pinctrl-bm1880.c
> index b0000fe5b31d..387798fb09be 100644
> --- a/drivers/pinctrl/pinctrl-bm1880.c
> +++ b/drivers/pinctrl/pinctrl-bm1880.c
> @@ -1298,7 +1298,7 @@ static const struct pinmux_ops bm1880_pinmux_ops = {
> .set_mux = bm1880_pinmux_set_mux,
> };
>
> -static struct pinctrl_desc bm1880_desc = {
> +static const struct pinctrl_desc bm1880_desc = {
> .name = "bm1880_pinctrl",
> .pins = bm1880_pins,
> .npins = ARRAY_SIZE(bm1880_pins),
> diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
> index 558fc2ad976f..99ae0b4e308a 100644
> --- a/drivers/pinctrl/pinctrl-k210.c
> +++ b/drivers/pinctrl/pinctrl-k210.c
> @@ -884,7 +884,7 @@ static const struct pinctrl_ops k210_pinctrl_ops = {
> .dt_free_map = pinconf_generic_dt_free_map,
> };
>
> -static struct pinctrl_desc k210_pinctrl_desc = {
> +static const struct pinctrl_desc k210_pinctrl_desc = {
> .name = "k210-pinctrl",
> .pins = k210_pins,
> .npins = K210_NPINS,
> diff --git a/drivers/pinctrl/pinctrl-lpc18xx.c b/drivers/pinctrl/pinctrl-lpc18xx.c
> index 0f5a7bed2f81..5e0201768323 100644
> --- a/drivers/pinctrl/pinctrl-lpc18xx.c
> +++ b/drivers/pinctrl/pinctrl-lpc18xx.c
> @@ -1257,7 +1257,7 @@ static const struct pinctrl_ops lpc18xx_pctl_ops = {
> .dt_free_map = pinctrl_utils_free_map,
> };
>
> -static struct pinctrl_desc lpc18xx_scu_desc = {
> +static const struct pinctrl_desc lpc18xx_scu_desc = {
> .name = "lpc18xx/43xx-scu",
> .pins = lpc18xx_pins,
> .npins = ARRAY_SIZE(lpc18xx_pins),
> diff --git a/drivers/pinctrl/pinctrl-mlxbf3.c b/drivers/pinctrl/pinctrl-mlxbf3.c
> index ffb5dda364dc..fcd9d46de89f 100644
> --- a/drivers/pinctrl/pinctrl-mlxbf3.c
> +++ b/drivers/pinctrl/pinctrl-mlxbf3.c
> @@ -231,7 +231,7 @@ static const struct pinmux_ops mlxbf3_pmx_ops = {
> .gpio_request_enable = mlxbf3_gpio_request_enable,
> };
>
> -static struct pinctrl_desc mlxbf3_pin_desc = {
> +static const struct pinctrl_desc mlxbf3_pin_desc = {
> .name = "pinctrl-mlxbf3",
> .pins = mlxbf3_pins,
> .npins = ARRAY_SIZE(mlxbf3_pins),
> diff --git a/drivers/pinctrl/pinctrl-tb10x.c b/drivers/pinctrl/pinctrl-tb10x.c
> index c3b76e6511ac..bc76c91cf343 100644
> --- a/drivers/pinctrl/pinctrl-tb10x.c
> +++ b/drivers/pinctrl/pinctrl-tb10x.c
> @@ -735,7 +735,7 @@ static const struct pinmux_ops tb10x_pinmux_ops = {
> .set_mux = tb10x_pctl_set_mux,
> };
>
> -static struct pinctrl_desc tb10x_pindesc = {
> +static const struct pinctrl_desc tb10x_pindesc = {
> .name = "TB10x",
> .pins = tb10x_pins,
> .npins = ARRAY_SIZE(tb10x_pins),
> diff --git a/drivers/pinctrl/pinctrl-zynq.c b/drivers/pinctrl/pinctrl-zynq.c
> index 0e8de27d0de8..4dc9c252e2ef 100644
> --- a/drivers/pinctrl/pinctrl-zynq.c
> +++ b/drivers/pinctrl/pinctrl-zynq.c
> @@ -1143,7 +1143,7 @@ static const struct pinconf_ops zynq_pinconf_ops = {
> .pin_config_group_set = zynq_pinconf_group_set,
> };
>
> -static struct pinctrl_desc zynq_desc = {
> +static const struct pinctrl_desc zynq_desc = {
> .name = "zynq_pinctrl",
> .pins = zynq_pins,
> .npins = ARRAY_SIZE(zynq_pins),
> diff --git a/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c b/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c
> index 6df7a310c7ed..657385978edb 100644
> --- a/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c
> +++ b/drivers/pinctrl/starfive/pinctrl-starfive-jh7100.c
> @@ -903,7 +903,7 @@ static const struct pinconf_ops starfive_pinconf_ops = {
> .is_generic = true,
> };
>
> -static struct pinctrl_desc starfive_desc = {
> +static const struct pinctrl_desc starfive_desc = {
> .name = DRIVER_NAME,
> .pins = starfive_pins,
> .npins = ARRAY_SIZE(starfive_pins),
Acked-by: Thibault Ferrante <thibault.ferrante at canonical.com>
More information about the kernel-team
mailing list