NACK/Cmnt: [SRU][kernel-snaps-uc24.04/pc][PATCH 0/2] snapcraft.yaml: rename components, bug fixes

[Stefan Bader]

On 20.03.25 01:57, Aaron Jauregui wrote:
> [Impact]
> Nvidia 550 components correspond to the 550-server (ERD) driver. This is
> ambiguous due to the 550 uda also being a possible driver to support.
> Renaming nvidia-550-ko and nvidia-550-user to nvidia-550-erd-ko and
> nvidia-550-erd-user. Graphics testing found that userspace libraries
> are being mixed between ERD and UDA versions as well.
> 
> Caught a couple of non-server libraries being used which would break
> graphical installs as well.
> 
> [Fix]
> - Use -server libraries for libnvidia-extra and xserver-xorg-video-nvidia
> - rename nvidia-550-ko and nvidia-550-server to nvidia-550-erd-ko and
>    nvidia-550-erd-server.
> - Fix bug in version regex for ko component to allow for pulling respun
>    packages.
> 
> [Test case]
> Rebuilt and booted.
> 
> [Where problems could occur]
> Changing the name of the nvidia-550-erd components should not be a
> problem, as no public version using the old nvidia-550 naming scheme
> exists yet.
> 
> 
> Aaron Jauregui (2):
>    snapcraft.yaml: use -server libraries, rename 550 to 550-erd
>    snapcraft.yaml: fix respin fetch
> 
>   snapcraft.yaml | 65 +++++++++++++++++++++++++++-----------------------
>   1 file changed, 35 insertions(+), 30 deletions(-)
> 

Rejected for the following reasons:

Sorry I completely lost track on what would still be required and what 
not. For that reason I am rejecting all existing submissions. There was 
quite some rework done to make uc24 working which I was no part of. So 
please double check the current repo content and submit anything still 
outstanding (again). Sorry for the trouble.

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 47863 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250416/0013a0e4/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250416/0013a0e4/attachment-0001.sig>