ACK/Cmnt: [SRU][N][PATCH v3 0/2] Included missing upstream commits for LP: #2102181

[Manuel Diewald]

On Tue, Apr 15, 2025 at 01:12:18PM +0300, Mehmet Basaran wrote:
> BugLink: https://bugs.launchpad.net/bugs/2107336

Please add the SRU template to the LP bug as well (Impact, Fix, Test
etc sections).

> 
> [ Impact ]
> When applying upstream stable patchset (v6.6.67, v6.12.6) we forgot to include:
> 
> acea3779b2aa libperf cpumap: Add any, empty and min helpers
> 
> As a result perf (from tools) fails to compile.
> 
> [ Fix ]
> Included missing upstream commits for LP: #2102181 (Upstream stable to v6.6.67, v6.12.6)
> commits:
> b6b4a62d8525 libperf cpumap: Add any, empty and min helpers
> dcd45b376d0a libperf cpumap: Ensure empty cpumap is NULL from alloc

At a quick glance it does look like the new empty helper is relying on
empty cpumaps to be NULL, so I agree that we should include this second
commit, even though it does not directly address the issue of this LP
bug.

> 
> [Test]
> Compile and build tested.
> 
> [Where problems could occur]
> Patches are pretty safe (only additions) and unlikely to introduce bugs.

This section is supposed to be a description of how issues with these
patches would manifest, so that it would be easier to identify them as
the culprit of a certain problem later on. It is not necessarily only an
assessment of how likely bugs are or how trivial the changes might be.
Just something to keep in mind for future submissions. :)

> 
> 
> Ian Rogers (2):
>   libperf cpumap: Add any, empty and min helpers
>   libperf cpumap: Ensure empty cpumap is NULL from alloc
> 
>  tools/lib/perf/cpumap.c              | 33 +++++++++++++++++++++++++++-
>  tools/lib/perf/include/perf/cpumap.h | 16 ++++++++++++++
>  tools/lib/perf/libperf.map           |  4 ++++
>  3 files changed, 52 insertions(+), 1 deletion(-)
> 
> -- 
> 2.43.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Manuel Diewald <manuel.diewald at canonical.com>

-- 
 Manuel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250415/d615ac2e/attachment.sig>