NACK: [SRU][canonical-kernel-snaps/main][PATCH 2/2] nvidia-hooks: follow symlinks in module hooks

[Juerg Haefliger]

On Mon, 31 Mar 2025 09:27:04 +1100
Aaron Jauregui <aaron.jauregui at canonical.com> wrote:

> Signed-off-by: Aaron Jauregui <aaron.jauregui at canonical.com>
> ---
>  hooks/module/install.module      | 4 ++--
>  hooks/module/post-refresh.module | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/hooks/module/install.module b/hooks/module/install.module
> index 8fb6b8e..d61ae8b 100755
> --- a/hooks/module/install.module
> +++ b/hooks/module/install.module
> @@ -17,5 +17,5 @@ fi
>  rm -rf "$dest"
>  mkdir -p "$dest"
>  
> -find "$SNAP_COMPONENT" -name '*.ko' -exec cp '{}' "$dest" \;
> -find "$SNAP_COMPONENT" -name '*.ko.zst' -exec cp '{}' "$dest" \;
> +find -L "$SNAP_COMPONENT" -name '*.ko' -exec cp '{}' "$dest" \;
> +find -L "$SNAP_COMPONENT" -name '*.ko.zst' -exec cp '{}' "$dest" \;
> diff --git a/hooks/module/post-refresh.module b/hooks/module/post-refresh.module
> index 8fb6b8e..d61ae8b 100755
> --- a/hooks/module/post-refresh.module
> +++ b/hooks/module/post-refresh.module
> @@ -17,5 +17,5 @@ fi
>  rm -rf "$dest"
>  mkdir -p "$dest"
>  
> -find "$SNAP_COMPONENT" -name '*.ko' -exec cp '{}' "$dest" \;
> -find "$SNAP_COMPONENT" -name '*.ko.zst' -exec cp '{}' "$dest" \;
> +find -L "$SNAP_COMPONENT" -name '*.ko' -exec cp '{}' "$dest" \;
> +find -L "$SNAP_COMPONENT" -name '*.ko.zst' -exec cp '{}' "$dest" \;

Why this change? This needs an explanation in the commit message. Is this a
fix? Or a required change to support a new feature?

...Juerg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20250415/894e678e/attachment.sig>