APPLIED[N]/Cmnt: [SRU][O/N][PATCH v3 0/1] reenable libtraceevent

Stefan Bader stefan.bader at canonical.com
Wed Sep 25 12:45:50 UTC 2024


On 30.08.24 18:34, Bethany Jamison wrote:
> BugLink: https://bugs.launchpad.net/bugs/2076190
> 
> Reenable LIBTRACEEVENT - it was disabled in commit 92550b568d (UBUNTU:
> [Packaging] perf: build without libtraceevent) to temporarily reduce
> the amount of build dependecies. According to LP#2076190 disabling
> libtraceevent has reduced much of the functionality of perf. Perf is
> no longer able to perform any operations on tracepoints.
> 
> It looks like libtraceevent was originally disabled for no other
> reason than to reduce the number of build dependencies - and it even
> seems like this disablement was not intended to be permenent (from
> commit message: "Disable libtraceevent in perf to avoid adding extra
> build dependencies for now.") I think there is no significant tradeoff
> in reenabling libtraceevent as it is fixing a regression in
> functionality introduced by commit 92550b568d.
> 
> v2: explain purpose of patch in greater detail as well as include a
> buglink
> 
> v3: I build-tested both Noble/Oracular on LP PPAs, since v2 one of the
> files in my patchset was modified and created a conflict with a
> neighboring line (doesn't affect my changes), so I remade the patches
> 
> Bethany Jamison (1):
>    UBUNTU: [Packaging] perf: reenable libtraceevent
> 
>   debian/rules.d/2-binary-arch.mk  | 4 ++--
>   debian/rules.d/3-binary-indep.mk | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 

I actually had the same problem as Timo. Attempted both patches and 
neither worked. So I just manually dropped NO_LIBTRACEEVENT=1 in those 4 
places. Also changed the BugLink to be the standard format we use. And 
added a little additional  commentary.

Applied to noble:linux/master-next. Thanks.

-Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240925/a7b5d870/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240925/a7b5d870/attachment-0001.sig>


More information about the kernel-team mailing list