ACK: [SRU][J:linux-bluefield][PATCH v1 0/1] Backport sched: act_ct: take care of padding in struct zones_ht_key

Fri Sep 13 14:34:46 UTC 2024

On Wed, Sep 11, 2024 at 6:59 PM Feng Liu <feliu at nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2080318
>
> Got call trace RIP below, internal bug ID: 4059202
>  [ 747.269287] WARNING: CPU: 3 PID: 8360 at include/net/netfilter/nf_flow_table.h:261 mlx5_tc_ct_del_ft_cb.part.0+0x17b/0x1c0 [mlx5_core]
>
> * Solution
> Need to backport
> "sched: act_ct: take care of padding in struct zones_ht_key"
>
> * Full call trace
>
> 3] mlx5_core 0000:08:00.1: mlx5_wait_for_pages:919:(pid 8360): Skipping wait for vf pages stage
>  [ 744.780536] mlx5_core 0000:08:00.1: E-Switch: cleanup
>  [ 747.086729] mlx5_core 0000:08:00.0: E-Switch: Unload vfs: mode(OFFLOADS), nvfs(2), necvfs(0), active vports(2)
>  [ 747.268720] ------------[ cut here ]------------
>  [ 747.269287] WARNING: CPU: 3 PID: 8360 at include/net/netfilter/nf_flow_table.h:261 mlx5_tc_ct_del_ft_cb.part.0+0x17b/0x1c0 [mlx5_core]
>  [ 747.270709] Modules linked in: rdma_ucm(OE) rdma_cm(OE) iw_cm(OE) ib_ipoib(OE) ib_cm(OE) ib_umad(OE) ib_uverbs(OE) fwctl(OE) mlx5_core(OE-) mlxfw(OE) auxiliary(OE) mlxdevm(OE) ib_core(OE) memtrack(OE) mlx_compat(OE) psample(E) ptp(E) pps_core(E) act_gact(E) act_mirred(E) cls_flower(E) act_ct(E) nf_flow_table(E) sch_ingress(E) openvswitch(E) nsh(E) nf_conncount(E) nfsv3(E) nfs_acl(E) xt_conntrack(E) xt_MASQUERADE(E) nf_conntrack_netlink(E) nfnetlink(E) xt_addrtype(E) iptable_filter(E) iptable_nat(E) nf_nat(E) br_netfilter(E) bridge(E) rpcsec_gss_krb5(E) stp(E) llc(E) auth_rpcgss(E) nfsv4(E) dns_resolver(E) nfs(E) lockd(E) grace(E) fscache(E) netfs(E) overlay(E) rfkill(E) sunrpc(E) kvm_intel(E) iTCO_wdt(E) kvm(E) iTCO_vendor_support(E) irqbypass(E) i2c_i801(E) virtio_net(E) pcspkr(E) lpc_ich(E) net_failover(E) i2c_smbus(E) mfd_core(E) failover(E) sch_fq_codel(E) drm(E) i2c_core(E) ip_tables(E) crc32_pclmul(E) crc32c_intel(E) ghash_clmulni_intel(E) sha256_ssse3(E) sha1_ssse3(E)
>  [ 747.270734] serio_raw(E) fuse(E) [last unloaded: mlx5_fwctl]
>  [ 747.280452] CPU: 3 PID: 8360 Comm: modprobe Tainted: G OE 5.15.0-1052.39.ga4f8915-bluefield #1
>  [ 747.281539] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014
>  [ 747.282751] RIP: 0010:mlx5_tc_ct_del_ft_cb.part.0+0x17b/0x1c0 [mlx5_core]
>  [ 747.283557] Code: ff 8b 75 0c 49 8b bd 10 02 00 00 e8 5f d5 fd ff 48 83 fd 10 77 1b 48 83 c4 28 48 89 ef 5b 5d 41 5c 41 5d 41 5e e9 c5 39 54 e0 <0f> 0b e9 14 ff ff ff 48 c7 c7 c0 17 e6 a0 e8 f2 c0 46 ff 85 c0 75
>  [ 747.285551] RSP: 0018:ffa000000141f798 EFLAGS: 00010246
>  [ 747.286148] RAX: 0000000000000000 RBX: ff1100013dc7d040 RCX: ff1100013dc7d148
>  [ 747.286933] RDX: ff1100013dc7ca00 RSI: ffffffffa0dace30 RDI: ff1100013dc7d148
>  [ 747.287713] RBP: ff1100013dc7ca00 R08: 0000000000000000 R09: ff110001048dc8a0
>  [ 747.288498] R10: ff1100011604d9b0 R11: 0000000000000001 R12: ff1100011f4169f0
>  [ 747.289279] R13: ff1100011f416800 R14: ff1100013dc7d158 R15: ff110001078a0000
>  [ 747.290060] FS: 00007f51138e0740(0000) GS:ff1100085f6c0000(0000) knlGS:0000000000000000
>  [ 747.290962] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>  [ 747.291611] CR2: 000056383bead180 CR3: 0000000101a7a006 CR4: 0000000000771ee0
>  [ 747.292395] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
>  [ 747.293186] DR3: 0000000000000000 DR6: 00000000fffe07f0 DR7: 0000000000000400
>  [ 747.293966] PKRU: 55555554
>  [ 747.294308] Call Trace:
>  [ 747.294630] <TASK>
>  [ 747.294916] ? __warn+0x7d/0xc0
>  [ 747.295305] ? mlx5_tc_ct_del_ft_cb.part.0+0x17b/0x1c0 [mlx5_core]
>  [ 747.296043] ? report_bug+0xd0/0x100
>  [ 747.296479] ? handle_bug+0x35/0x80
>  [ 747.296901] ? exc_invalid_op+0x14/0x70
>  [ 747.297358] ? asm_exc_invalid_op+0x16/0x20
>  [ 747.297853] ? mlx5_tc_ct_block_flow_offload_add+0xa70/0xa70 [mlx5_core]
>  [ 747.298640] ? mlx5_tc_ct_del_ft_cb.part.0+0x17b/0x1c0 [mlx5_core]
>  [ 747.299371] ? mlx5_tc_ct_del_ft_cb.part.0+0x4c/0x1c0 [mlx5_core]
>  [ 747.300092] ? mapping_remove+0x108/0x130 [mlx5_core]
>  [ 747.300718] mlx5_tc_ct_delete_flow+0x7a/0xa0 [mlx5_core]
>  [ 747.301379] mlx5_free_flow_attr_actions+0xea/0x2a0 [mlx5_core]
>  [ 747.302089] mlx5e_tc_del_fdb_flow+0x199/0x400 [mlx5_core]
>  [ 747.302754] mlx5e_flow_put+0x25/0x90 [mlx5_core]
>  [ 747.303338] mlx5e_delete_flower+0x1fe/0x280 [mlx5_core]
>  [ 747.303983] tc_setup_cb_reoffload+0x20/0x80
>  [ 747.304487] fl_reoffload+0x25b/0x310 [cls_flower]
>  [ 747.305096] ? mlx5e_rep_setup_ft_cb+0x150/0x150 [mlx5_core]
>  [ 747.305781] ? mlx5e_rep_setup_ft_cb+0x150/0x150 [mlx5_core]
>  [ 747.306462] tcf_block_playback_offloads+0x76/0x170
>  [ 747.307022] tcf_block_unbind+0x73/0xe0
>  [ 747.307480] tcf_block_setup+0x1a7/0x1f0
>  [ 747.307947] ? flow_block_cb_setup_simple+0xd7/0x210
>  [ 747.308525] tcf_block_offload_cmd.isra.0+0xf1/0x130
>  [ 747.309094] tcf_block_offload_unbind+0x43/0x70
>  [ 747.309622] __tcf_block_put+0x81/0x150
>  [ 747.310089] ingress_destroy+0x22/0x30 [sch_ingress]
>  [ 747.310671] qdisc_destroy+0x3b/0xb0
>  [ 747.311109] dev_shutdown+0x7a/0xb0
>  [ 747.311540] unregister_netdevice_many+0x2d1/0x690
>  [ 747.312101] unregister_netdevice_queue+0xcb/0x110
>  [ 747.312666] unregister_netdev+0x18/0x20
>  [ 747.313140] mlx5e_vport_rep_unload+0x83/0x220 [mlx5_core]
>  [ 747.313816] mlx5_esw_offloads_unload_rep+0x24/0x40 [mlx5_core]
>  [ 747.314544] mlx5_eswitch_unload_vf_vports+0x7a/0xd0 [mlx5_core]
>  [ 747.315275] mlx5_eswitch_disable_sriov.cold+0x60/0x27e [mlx5_core]
>  [ 747.316056] ? mlx5_core_disable_hca+0x73/0x90 [mlx5_core]
>  [ 747.316720] mlx5_device_disable_sriov+0x9c/0x160 [mlx5_core]
>  [ 747.317411] mlx5_sriov_disable+0x53/0x70 [mlx5_core]
>  [ 747.318031] remove_one+0x48/0xa0 [mlx5_core]
>  [ 747.318582] pci_device_remove+0x39/0xa0
>  [ 747.319060] device_release_driver_internal+0xf3/0x1f0
>  [ 747.319657] driver_detach+0x3f/0x80
>  [ 747.320092] bus_remove_driver+0x55/0xd0
>  [ 747.320573] pci_unregister_driver+0x22/0xb0
>  [ 747.321085] mlx5_cleanup+0xc/0x20 [mlx5_core]
>  [ 747.321680] __x64_sys_delete_module+0x18f/0x250
>  [ 747.322224] ? exit_to_user_mode_prepare+0x35/0x170
>  [ 747.322802] do_syscall_64+0x33/0x80
>  [ 747.323244] entry_SYSCALL_64_after_hwframe+0x66/0xd0
>  [ 747.323833] RIP: 0033:0x7f51139f788b
>  [ 747.324269] Code: 73 01 c3 48 8b 0d 9d 75 0e 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa b8 b0 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 6d 75 0e 00 f7 d8 64 89 01 48
>  [ 747.326323] RSP: 002b:00007fff5b337918 EFLAGS: 00000206 ORIG_RAX: 00000000000000b0
>  [ 747.327194] RAX: ffffffffffffffda RBX: 0000558d777f1370 RCX: 00007f51139f788b
>  [ 747.327986] RDX: 0000000000000000 RSI: 0000000000000800 RDI: 0000558d777f13d8
>  [ 747.328784] RBP: 0000558d777f1370 R08: 0000000000000000 R09: 0000000000000000
>  [ 747.329586] R10: 00007f5113a88ac0 R11: 0000000000000206 R12: 0000558d777f13d8
>  [ 747.330381] R13: 0000000000000000 R14: 0000558d777f1098 R15: 00007fff5b339c98
>  [ 747.331177] </TASK>
>  [ 747.331480] ---[ end trace 2fc9d0236665b5fe ]---
>
> Eric Dumazet (1):
>   sched: act_ct: take care of padding in struct zones_ht_key
>
>  net/sched/act_ct.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>

Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com>

--
Best regards,
Bartlomiej