NACK/Cmnt: [SRU][F][PATCH v2 0/1] UBUNTU: SAUCE: fix tcp NULL ptr deref

[Stefan Bader]

On 06.09.24 19:23, Bethany Jamison wrote:
> Buglink: https://bugs.launchpad.net/bugs/2077657
> 
> [Impact]
> 
> This patch fixes bug LP#2077657 where a system crash is reported due
> to a NULL pointer dereference in TCP. This is because of issues
> accurately tracking packets in the write or retransmit queues. This
> patch checks that the skb is non-null before trying to read the
> timestamp.
> 
> [Fix]
> 
> add a check that the skb is non-null before trying to read the timestamp
> 
> [Test]
> 
> Compile tested
> 
> [Where problems could occur]
> 
> This fix affects those who use tcp, an issue with this fix would be
> visible to the user via a system crash.
> 
> v2: adjusted to better match stable patch format
> 
> Bethany Jamison (1):
>    fix NULL ptr deref causing system crash
> 
>   include/net/tcp.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 

This should have the justification in the bug report (best is adding it 
to the top of the original description). But also explain why this is 
done as a SAUCE patch and not by picking something from upstream. The 
latter is IMO even more important as we try to deviate as little as 
possible from upstream. This could otherwise impact stable updates.

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240909/bd166033/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240909/bd166033/attachment-0001.sig>