ACK/Cmnt: [SRU][J][PATCH 0/1] CVE-2024-26661

[Hui Wang]

On 9/6/24 17:47, Stefan Bader wrote:
>>
>> Srinivasan Shanmugam (1):
>>    drm/amd/display: Add NULL test for 'timing generator' in
>>      'dcn21_set_pipe()'
>>
>>   drivers/gpu/drm/amd/display/dc/dcn21/dcn21_hwseq.c | 8 +++++++-
>>   1 file changed, 7 insertions(+), 1 deletion(-)
>>
>
> The backport description could less verbose in the commit message. 
> Apart from the adjusted file location it is basically adjusting for 
> unrelated code changes. Which you might have done. What that second 
> half of the original patch does is to drop checking for NULL pointers 
> which it does now at the beginning.
> The check for (abm && panel_cntl) exists even in the jammy code and 
> would now be unnecessarily done.
>
OK, got it. Thanks.

Hui.

> And just as a note, this is the same upstream: there is a slight 
> change change in the flow of execution. Maybe intentionally, who 
> knows. But before this change, even if abm and panel_cntl were NULL, 
> if dmcu was not then dce110_set_pipe would be run. Now, this will 
> never happen.
>
> Acked-by: Stefan Bader <stefan.bader at canonical.com>