[unstable][PATCH linux-signed 0/9] Refactor and test generate-control

[Masahiro Yamada]

On Tue, Oct 8, 2024 at 11:03 AM Agathe Porte <agathe.porte at canonical.com> wrote:
>
> The goal of this patch set is to introduce some Python testing for the
> generate-control script (which becomes generate_control.py).
>
> Agathe Porte (9):
>   UBUNTU: [Packaging] generate-control: use stdin and stdout
>   UBUNTU: [Packaging] introduce debian/scripts/test-generate-control.sh
>   UBUNTU: [Packaging] generate-control: fix 'os' imported but unused
>   UBUNTU: [Packaging] generate-control: reformat using black
>   UBUNTU: [Packaging] generate-control: split into functions
>   UBUNTU: [Packaging] generate-control: use full path to
>     parameterise-ancillaries in comment
>   UBUNTU: [Packaging] generate-control: rename to generate_control.py
>   UBUNTU: [Packaging] generate_control.py: pass everything by argument
>   UBUNTU: [Packaging] introduce test_generate_control.py



9/9 should delete ./debian/scripts/test-generate-control.sh
because it no longer works after 9/9 is applied.


$ ./debian/scripts/test-generate-control.sh
+ REFERENCE_FILE=debian/scripts/generate_control.py.ref
+ debian/scripts/generate_control.py oracular linux-signed
linux-generate 6.11.0-8.8 linux 6.11.0-8.8 6.11.0-8
+ diff -u debian/scripts/generate_control.py.ref -
diff: debian/scripts/generate_control.py.ref: No such file or directory
Exception ignored in: <_io.TextIOWrapper name='<stdout>' mode='w'
encoding='utf-8'>
BrokenPipeError: [Errno 32] Broken pipe


Other than that, it looks good to me.





>  debian/rules                            |   2 +-
>  debian/scripts/generate-control         | 141 ---------------
>  debian/scripts/generate_control.py      | 223 ++++++++++++++++++++++++
>  debian/scripts/test-generate-control.sh |  17 ++
>  debian/scripts/test_generate_control.py | 134 ++++++++++++++
>  5 files changed, 375 insertions(+), 142 deletions(-)
>  delete mode 100755 debian/scripts/generate-control
>  create mode 100755 debian/scripts/generate_control.py
>  create mode 100755 debian/scripts/test-generate-control.sh
>  create mode 100644 debian/scripts/test_generate_control.py
>
> --
> 2.45.2
>
>
> --
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team