NACK/Cmnt: [SRU][F/J 0/2][N 0/1][PATCH] CVE-2024-44942

[Massimiliano Pellizzer]

On Wed, 16 Oct 2024 at 08:30, Koichiro Den <koichiro.den at canonical.com> wrote:
>
> There is a follow-up commit (sort of fix commit) for the prereq you
> applied: a78118406d52 ("f2fs: use f2fs_{err,info}_ratelimited() for
> cleanup"), which I think should also be applied for Jammy and Focal
> if you pull the prereq.
>

Thanks for catching this. I will send a v2 soon.

> On Tue, Oct 01, 2024 at 06:49:47PM +0200, Massimiliano Pellizzer wrote:
> > [Impact]
> >
> > Add sanity check on F2FS_INLINE_DATA flag in inode during garbage
> > collection.
> >
> > [Fix]
> >
> > Noble:  Cherry picked the fix commit from linux-6.10.y
> > Jammy:  Backported both a prereq and the fix from linux-6.6.y
> > Focal:  Backported both a prereq and the fix from linux-6.6.y
> > Bionic: In progress
> > Xenial: In progress
> >
> > [Test Case]
> >
> > Compile and boot tested.
> > Moreover tested a f2fs partition using the command:
> > stress-ng --hdd 4 --hdd-ops 200000 --iomix 4 --timeout 120s --temp-path /path/to/f2fs
> >
> > [Where problems could occur]
> >
> > The fix affects the f2fs filesystem. An issue with this fix may lead to
> > kernel crashes, particularly during the garbage collection process.
> > Users may also notice filesystem inconsistencies and data corruption.
> >
> > Chao Yu (2):
> >   f2fs: support printk_ratelimited() in f2fs_printk()
> >   f2fs: fix to do sanity check on F2FS_INLINE_DATA flag in inode during
> >     GC
> >
> >  fs/f2fs/dir.c   |  5 ++---
> >  fs/f2fs/f2fs.h  | 38 ++++++++++++++++++++++----------------
> >  fs/f2fs/gc.c    | 10 ++++++++++
> >  fs/f2fs/super.c | 11 ++++++++---
> >  4 files changed, 42 insertions(+), 22 deletions(-)
> >
> > --
> > 2.43.0
> >
> >
> > --
> > kernel-team mailing list
> > kernel-team at lists.ubuntu.com
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team



-- 
Massimiliano Pellizzer