ACK: [SRU][J:linux-bluefield][PATCH 0/2] Backport net/sched: act_ct: Take per-cb reference to tcf_ct_flow_table

[Bartlomiej Zolnierkiewicz]

On Thu, Oct 10, 2024 at 2:05 AM William Tu <witu at nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2080318
>
> Backport the two patches to fix the crash issue on Bluefield.
>     WARNING: CPU: 21 PID: 3688 at include/net/netfilter/nf_flow_table.h:262 mlx5_tc_ct_del_ft_cb+0x267/0x2b0 [mlx5_core]
>     Modules linked in: act_ct nf_flow_table act_mirred act_skbedit act_tunnel_key vxlan cls_matc
> hall nfnetlink_cttimeout act_gact cls_flower sch_ingress mlx5_vdpa vringh vhost_iotlb vdpa bonding openvswitch n
> sh rpcrdma rdma_ucm
>     ib_iser libiscsi scsi_transport_iscsi ib_umad rdma_cm ib_ipoib iw_cm ib_cm mlx5_ib ib_uverbs ib_core xt_MASQ
> UERADE nf_conntrack_netlink nfnetlink iptable_nat xt_addrtype xt_conntrack nf_nat br_netfilter rpcsec_gss_krb5 a
> uth_rpcgss oid_regis
>     Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.13.0-0-gf21b5a4aeb02-prebuilt
> .qemu.org 04/01/2014
>     Workqueue: mlx5e mlx5e_rep_neigh_update [mlx5_core]
>     RIP: 0010:mlx5_tc_ct_del_ft_cb+0x267/0x2b0 [mlx5_core]
>     Code: 89 ef 48 83 05 71 a4 14 00 01 e8 f4 06 04 e1 48 83 05 6c a4 14 00 01 48 83 c4 28 5b 5d 41 5c 41 5d c3 48 83 05 d1 8b 14 00 01 <0f> 0b 48 83 05 d7 8b 14 00 01 e9 96 fe ff ff 48 83 05 a2 90 14 00
>     RSP: 0018:ffff88813ff0fcb8 EFLAGS: 00010202
>     RAX: 0000000000000000 RBX: ffff88811eabac40 RCX: ffff88811eabad48
>     RDX: ffff88811eab8000 RSI: ffffffffa02cd560 RDI: 0000000000000000
>     RBP: ffff88811eab8000 R08: 0000000000000001 R09: ffffffffa0229700
>     R10: ffff888103538fc0 R11: 0000000000000001 R12: ffff88811eabad58
>     R13: ffff888110c01c00 R14: ffff888106b40000 R15: 0000000000000000
>     FS:  0000000000000000(0000) GS:ffff88885fd40000(0000) knlGS:0000000000000000
>     CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
>     CR2: 00007f1cefd28cb0 CR3: 000000012181b006 CR4: 0000000000370ea0
>     DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
>     DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
>     Call Trace:
>      <TASK>
>      ? __warn+0x79/0x120
>      ? mlx5_tc_ct_del_ft_cb+0x267/0x2b0 [mlx5_core]
>      ? report_bug+0x17c/0x190
>      ? handle_bug+0x3c/0x60
>
> Vlad Buslov (1):
>   net/sched: act_ct: Take per-cb reference to tcf_ct_flow_table
>
> Xin Long (1):
>   net: sched: call tcf_ct_params_free to free params in tcf_ct_init
>
>  include/net/netfilter/nf_flow_table.h | 10 ++++
>  net/sched/act_ct.c                    | 77 +++++++++++++++++++--------
>  2 files changed, 64 insertions(+), 23 deletions(-)
>

Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com>

--
Best regards,
Bartlomiej