CMT: Re: [SRU][n:linux-gcp/o:linux-gcp][PATCH 1/1] UBUNTU: [Config] Mark sev-guest as built-in

[Magali Lemes]

Hi!

On 08/10/2024 00:27, Guoqing Jiang wrote:
> 
> 
> On 10/8/24 03:06, Magali Lemes wrote:
>> BugLink: https://bugs.launchpad.net/bugs/2083848
>>
>> Signed-off-by: Magali Lemes <magali.lemes at canonical.com>
>> ---
>>   debian.gcp/config/annotations | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/debian.gcp/config/annotations 
>> b/debian.gcp/config/annotations
>> index 01bb2d53b2f6..eca7321041ff 100644
>> --- a/debian.gcp/config/annotations
>> +++ b/debian.gcp/config/annotations
>> @@ -59,6 +59,11 @@ CONFIG_RAID6_PQ_DEFAULT_ALG_BOOL                
>> note<'LP:1812728'>
>>   CONFIG_RUST                                     policy<{'amd64': 
>> 'n', 'arm64': '-'}>
>>   CONFIG_RUST                                     note<'TODO: update 
>> note'>
>> +CONFIG_SEV_GUEST                                policy<{'amd64': 'y'}>
>> +CONFIG_SEV_GUEST                                note<'LP: #2083848'>
>> +
>> +CONFIG_TSM_REPORTS                              policy<{'amd64': 'y'}>
>> +CONFIG_TSM_REPORTS                              note<'LP: #2083848, 
>> selected by CONFIG_SEV_GUEST'>
> 
> Does TSM_REPORTS need to be changed here? If so, would be better to 
> mention the option in subject and cover-letter too.
> 

Yes, CONFIG_TSM_REPORTS gets selected whenever we enable 
CONFIG_SEV_GUEST. The patch goal is to have the sev-guest module as 
built-in and for that to happen we need to set CONFIG_SEV_GUEST=y, which 
ends up also "selecting" CONFIG_TSM_REPORTS. Due to that, I'd argue that 
the subject is aligned with the patch content, since in order to have 
sev-guest built-in we need these two config options to be set to 'y'.
Maybe changing the [Fix] section in the BugLink description to also 
mention CONFIG_TSM_REPORTS would be enough? Or would a v2 changing the 
cover letter content be needed too?


Best regards,
Magali

> Thanks,
> Guoqing