[SRU][O][PATCH 08/18] serial: qcom-geni: fix arg types for qcom_geni_serial_poll_bit()

Juerg Haefliger juerg.haefliger at canonical.com
Tue Nov 26 08:50:03 UTC 2024


From: Douglas Anderson <dianders at chromium.org>

BugLink: https://bugs.launchpad.net/bugs/2089237

The "offset" passed in should be unsigned since it's always a positive
offset from our memory mapped IO.

The "field" should be u32 since we're anding it with a 32-bit value
read from the device.

Suggested-by: Stephen Boyd <swboyd at chromium.org>
Signed-off-by: Douglas Anderson <dianders at chromium.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio at linaro.org>
Link: https://lore.kernel.org/r/20240610152420.v4.4.I24a0de52dd7336908df180fa6b698e001f3aff82@changeid
Tested-by: NĂ­colas F. R. A. Prado <nfraprado at collabora.com>
Signed-off-by: Johan Hovold <johan+linaro at kernel.org>
Link: https://lore.kernel.org/r/20240906131336.23625-5-johan+linaro@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
(cherry picked from commit c2eaf5e01275ae13f1ec5b1434f6c49cfff57430)
Signed-off-by: Juerg Haefliger <juerg.haefliger at canonical.com>
---
 drivers/tty/serial/qcom_geni_serial.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index b88435c0ea50..54052c68555d 100644
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -266,7 +266,7 @@ static bool qcom_geni_serial_secondary_active(struct uart_port *uport)
 }
 
 static bool qcom_geni_serial_poll_bit(struct uart_port *uport,
-				int offset, int field, bool set)
+				      unsigned int offset, u32 field, bool set)
 {
 	u32 reg;
 	struct qcom_geni_serial_port *port;
-- 
2.43.0




More information about the kernel-team mailing list