NAK: [SRU][Oracular][PATCH 1/1] hid-asus: use hid for brightness control

[Agathe Porte]

Hello Mitchell,

2024-11-20 05:12 CET, Mitchell Augustin:
> From: "Mitchell Augustin" <mitchell.augustin at canonical.com>
> 
> From: "Luke D. Jones" <luke at ljones.dev>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2089113
> 
> On almost all ASUS ROG series laptops the MCU used for the USB keyboard
> also has a HID packet used for setting the brightness. This is usually
> the same as the WMI method. But in some laptops the WMI method either
> is missing or doesn't work, so we should default to the HID control.
> 
> Signed-off-by: Luke D. Jones <luke at ljones.dev>
> Signed-off-by: Mitchell Augustin <mitchell.augustin at canonical.com>

Please attach your cover letter together with the patch using
`git send-email --cover --compose ...`. Since the first send
failed you might as well want to use v2 with `-v2` option.

Please use short buglink in cover letter and commit ie.
https://bugs.launchpad.net/bugs/2089113

Please use SRU template in your bug and in your cover letter.

If this is an upstream cherry-pick (it should) then it is missing the
original commit info. Please use `git cherry-pick -sx` from the upstream
tree. If not upstream yet, send upstream and cherry-pick when accepted
and arrived in linux-next.

I strongly suggest you look at other submissions on the list for
inspiration:
https://lists.ubuntu.com/archives/kernel-team/

Thanks.

Agathe.