NACK/Cmnt: [SRU][Oracular][PATCH 0/1] hid-asus: use hid for brightness control

[Stefan Bader]

On 20.11.24 05:11, Mitchell Augustin wrote:
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2089113
> 
> [Impact]
> 
> The brightness of some ASUS ROG laptop keyboards cannot be adjusted
> without this patch.
> 
> [Test case]
> 
> I verified that this patch applies cleanly to the Oracular kernel
> at Ubuntu-6.11.0-9.9 and resolves the bug on my laptop
> (Asus ROG GA503RM). I observed no regressions. This can be verified
> on any similar model of laptop.
> 
> [Fix]
> 
> On almost all ASUS ROG series laptops the MCU used for the USB keyboard
> also has a HID packet used for setting the brightness. This is usually
> the same as the WMI method. But in some laptops the WMI method either
> is missing or doesn't work, so we should default to the HID control.
> 
> 
> [Regression potential]
> 
> I do not expect any regressions since this only touches parts of
> asus-wmi and hid-asus that are covered by my test case, which worked
> as intended.
> 
> 
> Luke D. Jones (1):
>    hid-asus: use hid for brightness control on keyboard
> 
>   drivers/hid/hid-asus.c                     |  7 +++++
>   drivers/platform/x86/asus-wmi.c            |  3 +-
>   include/linux/platform_data/x86/asus-wmi.h | 36 ++++++++++++++++++++++
>   3 files changed, 45 insertions(+), 1 deletion(-)
> 

Rejected for the following reasons:
- Patch not a reply to cover email (threaded)

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20241120/3ef6c76f/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20241120/3ef6c76f/attachment-0001.sig>