NACK/Cmt: [SRU Noble PATCH 0/1] Fix net:fib_rule_tests.sh in ubuntu_kselftests_net in SRU regression test

[Roxana Nicolescu]

On 27/05/2024 05:48, Masahiro Yamada wrote:
> On Fri, May 24, 2024 at 10:40 PM Roxana Nicolescu
> <roxana.nicolescu at canonical.com> wrote:
>>
>> On 22/05/2024 06:12, Masahiro Yamada wrote:
>>> BugLink: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/2066332
>>>
>>> [Impact]
>>> This is a change (fix) to kselftests. Of course, the kernel itself is not changed.
>>>
>>> Now, net:fib_rule_tests.sh in ubuntu_kselftests_net in rt (regression test)
>>> fails for all Noble kernels in our SRU cycles.
>>>
>>> This fixes it.
>>>
>>> [Fix]
>>>
>>> net:fib_rule_tests.sh in ubuntu_kselftests_net will be fixed.
>>>
>>> [Test Case]
>>>
>>> Just do a regression test, as we do in our normal SRU cycle.
>>>
>>> Or, you can directly run, tools/testing/selftests/net/fib_rule_tests.sh
>>>
>>>
>>>
>>> Masahiro Yamada (1):
>>>     Revert "UBUNTU: SAUCE: selftests: net: fix "from" match test in
>>>       fib_rule_tests.sh"
>>>
>>>    tools/testing/selftests/net/fib_rule_tests.sh | 2 --
>>>    1 file changed, 2 deletions(-)
>>>
>> Can you provide some extra info? Was this included in noble by mistake
>> by us?
>
> Did you read the  BugLink?
>
>    BugLink: https://bugs.launchpad.net/ubuntu-kernel-tests/+bug/2066332
You provided some details in the cover letter but not everything.
I am sorry for not reading the buglink, but I think you could have also 
provided the information
in the cover letter to avoid confusion. That's why we ask for a cover 
letter in the first place.
>
>
> "However, such a Ubuntu-local commit is often blindly
> carried over to future releases because nobody re-evaluates
> whether it is still needed or not."
>
>
>
> I believe the information that was already provided
> answered your question.
>
>
>
>
>> Or did it come from upstream stable? If the latter, we should discuss
>> this with upstream first.
>
> Again, see the BugLink.
>
>
> Also, you can check the commit prefix I am reverting.
>
>
> Revert "UBUNTU: SAUCE: selftests: net: fix ..."
>          ^^^^^^^^^^^^^^
>
>
> The prefix "UBUNTU: SAUCE:" clarifies this is a Ubuntu-local
> commit, doesn't it?
>
>
I missed this. It makes sense now.
>
>
>
>
>> Roxana
See inline. Please resubmit with the proper buglink format.
And the commit message should start with the buglink and then the rest.

Roxana