ACK/Cmnt: [SRU][M,J,F,B,X,T][PATCH 0/1] Remove getabis scripts

Roxana Nicolescu roxana.nicolescu at canonical.com
Wed Mar 27 09:35:10 UTC 2024


On 27/03/2024 07:35, Andrea Righi wrote:
> On Tue, Mar 26, 2024 at 05:16:36PM +0100, Roxana Nicolescu wrote:
>> BugLink: https://bugs.launchpad.net/bugs/2059143
>>
>> SRU Justification
>>
>> [Impact]
>> With ABI checks removed from the tree (#LP2055685), there's no need to
>> download the buildinfo from a previous version.
>>
>> [Fix]
>> This is needed only in the main kernels.
>> 1. remove the common getabis script
>> 2. remove per kernel getabis file (this will be done with cranky fix)
>>
>> [Test]
>> Build test on cbd. No issue found. Also cranked the kernels in advance to
>> see if there were issues, but no issue was found.
>>
>> [Regression potential]
>> In the current cycle, the ABI checks have been removed and this is not
>> used anymore. No issues have been found. Now we're just removing an unused
>> feature, therefore the regression potential is none.
> Thanks for doing this cleanup.
>
> I think we can also remove debian.master/etc/getabis at this point, but
> overall this looks good to me.
This will be done with cranky fix. Initially I wanted to do this here 
for the main kernels but I
would have sent different patches for each series because the file 
differs a bit.
So I chose the easy route.
> Acked-by: Andrea Righi <andrea.righi at canonical.com>



More information about the kernel-team mailing list