[SRU][M/J/F][PATCH v3 1/1] jfs: fix uaf in jfs_evict_inode

Bethany Jamison bethany.jamison at canonical.com
Fri Mar 22 17:10:38 UTC 2024


From: Edward Adam Davis <eadavis at qq.com>

When the execution of diMount(ipimap) fails, the object ipimap that has been
released may be accessed in diFreeSpecial(). Asynchronous ipimap release occurs
when rcu_core() calls jfs_free_node().

Therefore, when diMount(ipimap) fails, sbi->ipimap should not be initialized as
ipimap.

Reported-and-tested-by: syzbot+01cf2dbcbe2022454388 at syzkaller.appspotmail.com
Signed-off-by: Edward Adam Davis <eadavis at qq.com>
Signed-off-by: Dave Kleikamp <dave.kleikamp at oracle.com>
(cherry picked from commit e0e1958f4c365e380b17ccb35617345b31ef7bf3)
CVE-2023-52600
Signed-off-by: Bethany Jamison <bethany.jamison at canonical.com>
---
 fs/jfs/jfs_mount.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/jfs/jfs_mount.c b/fs/jfs/jfs_mount.c
index b83aae56a1f26..631b8bd3e4384 100644
--- a/fs/jfs/jfs_mount.c
+++ b/fs/jfs/jfs_mount.c
@@ -172,15 +172,15 @@ int jfs_mount(struct super_block *sb)
 	}
 	jfs_info("jfs_mount: ipimap:0x%p", ipimap);
 
-	/* map further access of per fileset inodes by the fileset inode */
-	sbi->ipimap = ipimap;
-
 	/* initialize fileset inode allocation map */
 	if ((rc = diMount(ipimap))) {
 		jfs_err("jfs_mount: diMount failed w/rc = %d", rc);
 		goto err_ipimap;
 	}
 
+	/* map further access of per fileset inodes by the fileset inode */
+	sbi->ipimap = ipimap;
+
 	return rc;
 
 	/*
-- 
2.34.1




More information about the kernel-team mailing list