NACK/Cmnt: [SRU J/M/N][PATCH 0/2] 22.04.04: megaraid_sas: Critical Bug Fixes

[Stefan Bader]

On 07.03.24 22:57, Michael Reed wrote:
> From: Michael Reed <Michael.Reed at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2046722
> 
> SRU Justification:
> 
> [Impact]
> 
> This update has been initiated to include a few critical bug fixes from upstream into the upcoming 22.04.04 point kernel. Below are the upstream commit IDs:
> 
> [Fix]
> 0938f9fa4208 scsi: megaraid_sas: Driver version update to 07.727.03.00-rc1
> 2d83fb023c90 scsi: megaraid_sas: Log message when controller reset is requested but not issued
> 8e3ed9e78651 scsi: megaraid_sas: Increase register read retry count from 3 to 30 for selected registers
> 0b0747d507bf scsi: megaraid_sas: Fix deadlock on firmware crashdump
> 2309df27111a scsi: megaraid_sas: Fix crash after a double completion
> 0808ed6ebbc2 scsi: megaraid_sas: Fix fw_crash_buffer_show()
> 
> The change log for the above commit IDs is small and doesn't require rigorous validation. So please include these patches.
> 
> [Test Plan]
> 
> 1. Driver load and unload
> 2. Create and delete different virtual drives (R0, R1, R5 etc.,)
> 3. create JBOD
> 4. Run IOs with different profiles (io_depth, io_size etc.,) on VD and JBOD
> 5. controller reset while running IOs
> 
> [ Where problems could occur ]
> It has a critical patch which fixes the issue related to various register reads. So IO runs and various internal commands where problems could occur
> [ Other Info ]
> 
> Jammy
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/jammy/+ref/lp_2046722_megaraid_sas_update
> 
> Mantic
> https://code.launchpad.net/~mreed8855/ubuntu/+source/linux/+git/mantic/+ref/lp_2046722_megaraid_sas_update
> 
> Noble
> These patches are already in Noble
> 
> Chandrakanth patil (2):
>    scsi: megaraid_sas: Log message when controller reset is requested but
>      not issued
>    scsi: megaraid_sas: Driver version update to 07.727.03.00-rc1
> 
>   drivers/scsi/megaraid/megaraid_sas.h        | 4 ++--
>   drivers/scsi/megaraid/megaraid_sas_fusion.c | 3 +++
>   2 files changed, 5 insertions(+), 2 deletions(-)
> 

Rejected for the following reasons:
- the submission is not clear about requirements for mantic and jammy
   those require further patches which are contained in the cover email
   as pull requests
- suggest to target noble with individual patches but include mantic
   and jammy with explicit pull request mails

[SRU N/M/J] Cover
+- [SRU N][PATCH 1/2]...
+- [SRU N][PATCH 2/2]...
+- [SRU M][PULL]...
+- [SRU J][PULL]...

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240321/8ca151a9/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240321/8ca151a9/attachment-0001.sig>