[SRU] [jammy xilinx-zynqmp 1/3] arm64: zynqmp: Sync clock labels with kr260 revB

Andrei Gherzan andrei.gherzan at canonical.com
Mon Mar 18 10:42:18 UTC 2024


On 24/03/14 09:36AM, Portia Stephens wrote:
> On Wed, Mar 13, 2024 at 8:12 PM Andrei Gherzan
> <andrei.gherzan at canonical.com> wrote:
> >
> > On 24/03/08 10:25AM, Portia Stephens wrote:
> > > From: Michal Simek <michal.simek at amd.com>
> > >
> > > BugLink: https://bugs.launchpad.net/bugs/2055241
> > >
> > > Board description describes the hard part of chip (PS) but programmable
> > > logic (PL) part is not described in this file. But clocks on the board are
> > > not only connected to PS but also wired to PL. And because two revisions
> > > are available where revA is using one si5332 and revB multiple clock chips
> > > using the same clock labels helping with keeping only one device tree
> > > overlay which targets PL. That's why synchronize clock labels and use
> > > labels from revB which are more generic.
> > > Unfortunately if there is driver for si5332 chip split could happen again
> > > but it is still worth to do it now and solve this issue when occurs.
> > >
> > > (cherry picked from commit bd1a7261325afa7526ed12fbaeb8f2e939bd02f8 linux-xlnx/xlnx_rebase_v6.6_LTS)
> >
> > The inclusion of the "cherry pick" inside the original git message was
> > confusing to me. After checking the original patches (e.g.
> > https://github.com/Xilinx/linux-xlnx/commit/bd1a7261325afa7526ed12fbaeb8f2e939bd02f8)
> > I can confirm that this is not inherited from it.
> 
> Would you expect the "cherry pick" to come directly before my
> signed-off-by line? I can fix it up when I apply.

My standard rule (and expectation) is that we append to the git log
message - except BugLink. I would keep this as a comment unless the
maintainer considers it essential. I don't see anything about this in
the documentation; hence, it does not warrant a resubmission.

-- 
Andrei Gherzan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240318/073a332a/attachment-0001.sig>


More information about the kernel-team mailing list