ACK Re: [PATCH 0/2][Noble] Support AMD Adaptive Backlight Management (ABM) for power profiles daemon >= 2.0

[Timo Aaltonen]

You-Sheng Yang kirjoitti 11.3.2024 klo 6.55:
> BugLink: https://bugs.launchpad.net/bugs/2056716
> 
> [Impact]
> 
> power-profiles-daemon >= 2.0 now utilizes AMD GPU panel_power_savings
> sysfs entry to set desired panel power saving level. Related kernel
> fixes are to be released in v6.9.
> 
> [Fix]
> 
> Two linux-next committed fixes are required. The first one introduces
> panel_power_savings sysfs entry itself, and the second one extends
> abmlevel sysfs entry to allow an auto mode.
> 
> [Test Case]
> 
> 1. Check existence of panel_power_savings sysfs entry:
> 
>     $ cat /sys/class/drm/card0-eDP-1/amdgpu/panel_power_savings
>     -1
> 
> 2. Remove power cable and switch between power profiles from Power
> Management settings. The content of above panel_power_savings sysfs
> entry should be updated correspondingly.
> 
> [Where problems could occur]
> 
> While the abmlevel entry now has a different default value that allows
> automatic power management, the behavior may differ from users'
> expectation.
> 
> [Other Info]
> 
> power-profiles-daemon >= 0.20 is only available on Noble or later at
> this moment, so only Noble/Unstable will be nominated for fix.
> 
> Hamza Mahfooz (2):
>    drm/amd/display: add panel_power_savings sysfs entry to eDP connectors
>    drm/amdgpu: respect the abmlevel module parameter value if it is set
> 
>   drivers/gpu/drm/amd/amdgpu/amdgpu.h           |  2 +-
>   drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       | 11 ++-
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 92 ++++++++++++++++++-
>   3 files changed, 95 insertions(+), 10 deletions(-)
> 

Acked-by: Timo Aaltonen <timo.aaltonen at canonical.com>


-- 
t