NACK/Cmnt: [SRU][M][PATCH v5 0/2] Dynamically determine acpi_handle_list size

Stefan Bader stefan.bader at canonical.com
Tue Mar 5 08:48:59 UTC 2024


On 01.03.24 08:51, Ivan Hu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2049733
> 
> [Impact]
> ACPI handle list will be dynamic allocated without default fixed size.
> 
> [Fix]
> Currently the ACPI_MAX_HANDLES is defined fix to 10, and it is not enough for
> some platforms that called ACPI _PSL method to get passive cooling device
> objects. then will get the error message "Invalid passive threshold", this
> patch change the fixed size with the dynamic handle list size which fixes the
> handle reference error.
> 
> [Test Case]
> check the dmesg to see if there is the error message "Invalid passive threshold"
> 
> [Where problems could occur]
> Only change the fixed size with the dynamic handle list size. Risk of regression
> is low.
> 
> [Other Info]
> Change of v2:
> add the "ACPI: utils: Fix error path in acpi_evaluate_reference()" patch for
> fixing the "ACPI: utils: Dynamically determine acpi_handle_list size" issue
> and modify the cherrypicked to backported
> Change of v3
> add missing [SRU][M]
> Change of v4
> add missing BugLinks
> Change of v5
> add backport explanation
> 
> Rafael J. Wysocki (2):
>    ACPI: utils: Dynamically determine acpi_handle_list size
>    ACPI: utils: Fix error path in acpi_evaluate_reference()
> 
>   drivers/acpi/acpi_lpss.c                      | 10 ++-
>   drivers/acpi/scan.c                           |  1 +
>   drivers/acpi/thermal.c                        | 29 ++++++---
>   drivers/acpi/utils.c                          | 63 ++++++++++++++++++-
>   .../platform/surface/surface_acpi_notify.c    | 10 ++-
>   include/acpi/acpi_bus.h                       |  9 ++-
>   6 files changed, 101 insertions(+), 21 deletions(-)
> 

Rejected for the following reasons:
- v6 on mailing list

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240305/05260130/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240305/05260130/attachment-0001.sig>


More information about the kernel-team mailing list