[PATCH 4/4][Noble] UBUNTU: SAUCE: x86/cacheinfo: Clean out init_cache_level()

You-Sheng Yang vicamo.yang at canonical.com
Mon Mar 4 10:32:06 UTC 2024


From: Ricardo Neri <ricardo.neri-calderon at linux.intel.com>

BugLink: https://bugs.launchpad.net/bugs/2049793

init_cache_level() no longer has a purpose on x86. It no longer needs to
set num_leaves, and it never had to set num_levels, which was unnecessary
on x86.

Replace it with "return 0" simply to override the weak function, which
would return an error.

Cc: Andreas Herrmann <aherrmann at suse.com>
Cc: Catalin Marinas <catalin.marinas at arm.com>
Cc: Chen Yu <yu.c.chen at intel.com>
CC: Huang Ying <ying.huang at intel.com>
Cc: Len Brown <len.brown at intel.com>
Cc: Radu Rendec <rrendec at redhat.com>
Cc: Pierre Gondois <Pierre.Gondois at arm.com>
Cc: Pu Wen <puwen at hygon.cn>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki at intel.com>
Cc: Sudeep Holla <sudeep.holla at arm.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada at linux.intel.com>
Cc: Will Deacon <will at kernel.org>
Cc: Zhang Rui <rui.zhang at intel.com>
Cc: linux-arm-kernel at lists.infradead.org
Cc: stable at vger.kernel.org
Reviewed-by: Len Brown <len.brown at intel.com>
Signed-off-by: Ricardo Neri <ricardo.neri-calderon at linux.intel.com>
(cherry-picked from https://lore.kernel.org/all/20231212222519.12834-5-ricardo.neri-calderon@linux.intel.com/raw)
Signed-off-by: You-Sheng Yang <vicamo.yang at canonical.com>
---
 arch/x86/kernel/cpu/cacheinfo.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/arch/x86/kernel/cpu/cacheinfo.c b/arch/x86/kernel/cpu/cacheinfo.c
index 4125e53a5ef79..1cfe0921ac677 100644
--- a/arch/x86/kernel/cpu/cacheinfo.c
+++ b/arch/x86/kernel/cpu/cacheinfo.c
@@ -1002,11 +1002,6 @@ static void ci_leaf_init(struct cacheinfo *this_leaf,
 
 int init_cache_level(unsigned int cpu)
 {
-	struct cpu_cacheinfo *this_cpu_ci = get_cpu_cacheinfo(cpu);
-
-	if (!this_cpu_ci)
-		return -EINVAL;
-	this_cpu_ci->num_levels = 3;
 	return 0;
 }
 
-- 
2.43.0




More information about the kernel-team mailing list