NACK: [SRU][M,J,F][PATCH 0/3] Cranky update-dkms-versions rollout

Roxana Nicolescu roxana.nicolescu at canonical.com
Mon Mar 4 09:27:47 UTC 2024


On 01/03/2024 16:06, Roxana Nicolescu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2055685
>
> SRU Justification
>
> [Impact]
> Having a common file for dkms-versions between main kernels and
> derivatives causes a lot of conflicts during rebase.
> Solution is to have a dkms-versions per kernels, under
> debian.<derivative>/dkms-version.
>
> While at it, instead of running ./update-dkms-version script, cranky
> update-dkms-versions was introduced.
>
> [Fix]
> This is needed only in the main kernels.
> 1. remove update-dkms-version script
> 2. rename debian/dkms-version with debian.master/dkms-versions
> 3. Replace debian/dkms-versions references in debian scripts and rules
> with $(DEBIAN)/dkms-versions
> The 3rd fix required separate patches because the scripts are a bit
> different.
>
> Note for derivatives: These changes will be inherited from the parent
> during cranky rebase.
> The only change to the cranky process is: instead of using
> ./update-dkms-versions
> script, cranky-update-dkms-versions should be used
>
> [Test]
> Build test on cbd. No issue found.
>
> [Regression pottential]
> Owners have tried this last cycle in derivatives and no issues were
> found.
> We may see build failures due to wrong dkms versions, but it will be
> fixed along the way.
>
> Roxana Nicolescu (3):
>    UBUNTU: [Packaging] remove update-dkms-versions
>    UBUNTU: Move debian/dkms-versions to debian.master/dkms-versions
>    UBUNTU: [Packaging] Replace debian/dkms-versions with $(DEBIAN)/dkms-versions
>
Will send a v2



More information about the kernel-team mailing list