ACK/Cmnt: [SRU mantic/linux, jammy/linux, focal/linux, bionic/linux, xenial/linux LP#2055686] drop internal ABI checks

[Stefan Bader]

On 01.03.24 15:09, Andy Whitcroft wrote:
> We currently check for ABI changes in the kernel packaging during kernel
> builds.  This prevents us building kernels which do not meet ABI
> constraints, for example those which unexpectedly drop a module.
> 
> This mechanism has some downsides.  Firstly we must maintain the
> internal copy of the ABI data from the previous kernel upload to
> facilitate delta detection.  Secondly configuration changes can lead to
> the loss of a module which is desired but not immediatly obvious leading
> to build failures and additional uploads must be performed to recover
> wasting developer time.
> 
> Our critical requirement is to not sign or release kernels which do not
> meet our criteria.  We already validate signing compatibility and
> upgradabilty externally gating signing and releasing on those criteria
> via the Stable Workflow Manager (SWM).  It makes sense to perform the
> ABI checks in the same manner.  SWM has already been modified to use the
> produced linux-buildinfo data to perform the equivalent checks and
> report those for the kernel via an `abi-testing` task on the associated
> tracker.  We therefore propose dropping ABI checks and history data
> from the main package trees.
> 
> Following this email are patches for all of the current live stable
> series.  Proposing for mantic/linux, jammy/linux, focal/linux,
> bionic/linux, and xenial/linux.
> 
> -apw
> 

Only did a rough glance. I would pay more attention when applying to my 
main kernel(s). For the older ones we need to check with security as 
there is only security cycles for those. For Mantic I saw a 
final-checks.porig which I assume should be dropped when applying the set.

Acked-by: Stefan Bader <stefan.bader at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240301/87d8f027/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240301/87d8f027/attachment-0001.sig>