ACK/Cmnt: [SRU][o/n/j:azure][PATCH 0/1] net: mana: Add support for page sizes other than 4KB on ARM64

[John Cabaj]

On 6/26/24 3:29 AM, Thibault Ferrante wrote:
> For Oracular, it's going to be merged part of 6.11 which is going to be the base of Oracular,
> is that needed to get it in earlier ?

Capturing some external discussion here:

John: "It's in linux-next at the moment, does that imply that it's guaranteed to make 6.11? If so, we can just apply to the earlier kernels."
Thibault (summarized): "The linux-next tree is the holding area for patches aimed at the next kernel merge window. Patches can always be removed if issues are discovered, but that's the exception, not the rule."

Further discussion captured here:

Understood. Given that I'm not sure when Oracular kernels will start to be tested by Azure, and the slight chance that the given patch is removed from 6.11 consideration, I would rather apply the patch, and drop it on rebase if the parent kernel brings in the patch from 6.11.


John

> 
> On 25-06-2024 23:09, John Cabaj wrote:
>> BugLink: https://bugs.launchpad.net/bugs/2070402
>>
>> [Impact]
>>
>> * Request from MSFT to add MANA support for page sizes other than 4KB
>>
>> [Fix]
>>
>> * Clean cherry pick from linux-next, 382d1741b5b2: "net: mana: Add support for page sizes other than 4KB on ARM64"
>> * Uses MANA_PAGE_SIZE, which defaults to 4KB, rather than PAGE_SIZE which is tied to platform page size
>>
>> [Test Plan]
>>
>> * Compile tested
>> * Boot tested
>> * Module loaded
>>
>> [Regression potential]
>>
>> * Changes isolated, minimal regression risk
>> * Functionally equivalent, simply changing the origin of defines
>>
>> [Other info]
>>
>> * SF #00388152
>>
>> Haiyang Zhang (1):
>>    net: mana: Add support for page sizes other than 4KB on ARM64
>>
>>   drivers/net/ethernet/microsoft/Kconfig            |  2 +-
>>   drivers/net/ethernet/microsoft/mana/gdma_main.c   | 10 +++++-----
>>   drivers/net/ethernet/microsoft/mana/hw_channel.c  | 14 +++++++-------
>>   drivers/net/ethernet/microsoft/mana/mana_en.c     |  8 ++++----
>>   drivers/net/ethernet/microsoft/mana/shm_channel.c | 13 +++++++------
>>   include/net/mana/gdma.h                           | 10 +++++++++-
>>   include/net/mana/mana.h                           |  3 ++-
>>   7 files changed, 35 insertions(+), 25 deletions(-)
>>
> 
> Acked-by: Thibault Ferrante <thibault.ferrante at canonical.com>
> 
> -- 
> Thibault
>