[SRU][Noble][PATCH 5/6] drm/i915/display: handle systems with duplicate psf gv points
Hui Wang
hui.wang at canonical.com
Tue Jun 25 06:53:06 UTC 2024
From: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
BugLink: https://bugs.launchpad.net/bugs/2070158
There could be multiple qgv and psf gv points with similar values.
Apparently pcode's handling of psf and qgv points are different. For
qgv case, pcode sets whatever is asked by the driver. But in case
of psf gv points, it compares the bw from points before setting the
mask. This can cause problems in scenarios where we have to disable
sagv by setting the highest bw point and there could be multiple
points with highest bw. So to set the maximum psf gv point, find
out all the points with the highest bw and set all together.
v1: - use the same treatment to qgv points as well (Vinod)
v2: - pcode confirms that for qgv points, it sets whatever the
driver sets (Vinod)
Reviewed-by: Jouni Högander <jouni.hogander at intel.com>
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>
Signed-off-by: Vinod Govindapillai <vinod.govindapillai at intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240405113533.338553-6-vinod.govindapillai@intel.com
(cherry picked from commit 1e9e4be8d683e192aa1f524c5cc554e9e50d1262)
Signed-off-by: Hui Wang <hui.wang at canonical.com>
---
drivers/gpu/drm/i915/display/intel_bw.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_bw.c b/drivers/gpu/drm/i915/display/intel_bw.c
index 9cbd85126984..a3ecb302ec14 100644
--- a/drivers/gpu/drm/i915/display/intel_bw.c
+++ b/drivers/gpu/drm/i915/display/intel_bw.c
@@ -874,6 +874,8 @@ static unsigned int icl_max_bw_psf_gv_point_mask(struct drm_i915_private *i915)
if (max_data_rate > max_bw) {
max_bw_point_mask = BIT(i);
max_bw = max_data_rate;
+ } else if (max_data_rate == max_bw) {
+ max_bw_point_mask |= BIT(i);
}
}
--
2.34.1
More information about the kernel-team
mailing list