[Oracular/Unstable][PATCH 0/4] UBUNTU: SAUCE: nvme-tcp: fix retry logic

Alexander Mikhalitsyn aleksandr.mikhalitsyn at canonical.com
Fri Jun 21 15:44:38 UTC 2024


BugLink: https://bugs.launchpad.net/bugs/2070048

[Impact]

* Request to port some out-of-upstream-tree patches to fix NVMe over TCP request retry logic issues

[Fix]

* Port patches from LKML:
https://lore.kernel.org/all/20230908100049.80809-1-hare@suse.de/

[Test Plan]

* It was tested internally in LXD team using a custom kernel build (linux-hwe-6.5 - 6.5.0-41.41~22.04.2ubuntu1nvmefixes) for Jammy:
https://launchpad.net/~mihalicyn/+archive/ubuntu/kernel-nvme-fixes/+packages

* SUSE kernel has these patches applied for a long time:
https://github.com/SUSE/kernel-source/blob/rpm-6.4.0-150600.21/patches.suse/nvme-tcp-do-not-terminate-commands-when-in-resetting.patch
https://github.com/SUSE/kernel-source/blob/rpm-6.4.0-150600.21/patches.suse/nvme-tcp-add-recovery_delay-to-sysfs.patch
https://github.com/SUSE/kernel-source/blob/rpm-6.4.0-150600.21/patches.suse/nvme-tcp-delay-error-recovery-until-the-next-kato.patch
https://github.com/SUSE/kernel-source/blob/rpm-6.4.0-150600.21/patches.suse/nvme-tcp-make-err_work-a-delayed-work.patch

[Regression potential]

* Limited to nvme-tcp block driver only

[Other Info]

Internal BugLink:
https://warthogs.atlassian.net/browse/LXD-1120

Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn at canonical.com>
Tested-by: Julian Pelizäus <julian.pelizaeus at canonical.com>

Daniel Wagner (1):
  nvme-tcp: add recovery_delay to sysfs

Hannes Reinecke (3):
  nvme-tcp: Do not terminate commands when in RESETTING
  nvme-tcp: make 'err_work' a delayed work
  nvme-tcp: delay error recovery until the next KATO interval

 drivers/nvme/host/core.c    |  3 ++-
 drivers/nvme/host/fabrics.c | 13 +++++++++++++
 drivers/nvme/host/fabrics.h |  3 +++
 drivers/nvme/host/nvme.h    |  1 +
 drivers/nvme/host/tcp.c     | 33 +++++++++++++++++++++++++++------
 5 files changed, 46 insertions(+), 7 deletions(-)


base-commit: 0ce1512b1fc6862aefb8cde3cfe4cb8b4d9dfe49
-- 
2.34.1




More information about the kernel-team mailing list