ACK/Cmnt: [SRU][Jammy][PATCH 1/1] UBUNTU: SAUCE: dmaengine: idxd: set is_visible member of idxd_wq_attribute_group

[Andrei Gherzan]

On 24/06/12 10:20am, Stefan Bader wrote:
> On 11.06.24 20:59, Jacob Martin wrote:
> > BugLink: https://bugs.launchpad.net/bugs/2069081
> > 
> > The backport of commit b0325aefd398 ("dmaengine: idxd: add WQ operation
> > cap restriction support") for K5.15 omitted a line setting the
> > is_visible callback of idxd_wq_attribute_group to the
> > idxd_wq_attr_visible function introduced in the same commit.
> > 
> > This results in the op_config attribute being accessible from userspace
> > when the underlying wq->opcap_bmap pointer used to service reads from it
> > is uninitialized, leading to a NULL pointer dereference when the
> > op_config attribute is read. Resolve this by setting the is_visible
> > callback as the upstream commit does.
> > 
> > Signed-off-by: Jacob Martin <jacob.martin at canonical.com>
> Acked-by: Stefan Bader <stefan.bader at canonical.com>
> > ---
> 
> Interesting how I managed to drop that bit. Good catch. I probably would add
> a standard

This begs the question of how could we have caught it in the first
place? interdiff is a good tool to catch or give hints of unexpected
differences between a backport and the original. It would be awesome to
have some automation that offers that for each submitted patch.

-- 
Andrei Gherzan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240614/30e1cdf3/attachment.sig>