ACK: [PATCH 0/1][SRU][N] a critical typo in the code managing the ASPM settings for PCI Express devices

Andrei Gherzan andrei.gherzan at canonical.com
Thu Jul 4 08:58:23 UTC 2024


On 24/07/04 02:43pm, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2071889
> 
> [Impact]
> The typo in the original code led to the PCI_EXP_LNKCTL register values
> being swapped between the parent PCI device and its child device.
> It may lead to incorrect power state, device malfunction on system
> resume, or potential data loss or system stability issues.
> 
> [Fix]
> Kaiheng submitted a patch to fix the issue and has been included in v6.9
> mainline kernel.
> f3d049b35b01 PCI/ASPM: Restore parent state to parent, child state to child
> 
> [Test]
> There is no test cases for the issue now.
> 
> [Where problems may occur]
> It fixes the typo and should not introduce any regression.
> 
> Kai-Heng Feng (1):
>   PCI/ASPM: Restore parent state to parent, child state to child
> 
>  drivers/pci/pcie/aspm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Andrei Gherzan <andrei.gherzan at canonical.com>

-- 
Andrei Gherzan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240704/71e66ae7/attachment.sig>


More information about the kernel-team mailing list