ACK: [SRU][J/L/M][PATCH 0/1] Audio balancing setting doesn't work with the cirrus codec

Jose Ogando jose.ogando at canonical.com
Wed Jan 31 14:29:58 UTC 2024


LGTM

Acked-by: Jose Ogando <jose.ogando at canonical.com>

On Wed, 2024-01-24 at 15:00 +0800, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2051050
> 
> Currently this patch is in the linux-next, and will be in the
> mainline kernel v6.8-rc2, there is no need to SRU this patch to Noble
> kernel, Noble kernel will have this patch automatically.
> 
> [Impact]
> In the gnome audio setting, if we adjust balancing setting, it
> doesn't
> work at all on a Dell machine with cirrus codec, that is because with
> the current driver, the exported amixer controls can't be handled by
> pulseaudio.
> 
> [Fix]
> Cherry-pick a mainline kernel patch, this could fix this issue.
> 
> [Test]
> Booted with the patched kernel, move the bar to the left or right to
> adjust the balance, we could hear the sound from left channel or
> right
> channel accordingly.
> 
> [Where problems could occur]
> This change will not create "Master Volume" amixer controls, probably
> will make the audio control malfunction, that is we couldn't control
> playback or capture volume correctly, but this regression possibility
> is very low, we already tested the patch on the machines with cirrus
> codec, they all worked well as before.
> 
> 
> Vitaly Rodionov (1):
>   ALSA: hda/cs8409: Suppress vmaster control for Dolphin models
> 
>  sound/pci/hda/patch_cs8409.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> -- 
> 2.34.1
> 
> 




More information about the kernel-team mailing list