ACK: [SRU][J:linux-bluefield][PATCH v1 0/1] mlxbf_gige: disable RX_DMA during NAPI poll

Bartlomiej Zolnierkiewicz bartlomiej.zolnierkiewicz at canonical.com
Mon Jan 22 15:35:57 UTC 2024


Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com>

On Fri, Jan 19, 2024 at 6:20 PM David Thompson <davthompson at nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2049930
>
> SRU Justification:
>
> [Impact]
>
> A regression has been introduced in the latest 22.04 kernel by including
> the following two commits:
>    revert "UBUNTU: SAUCE: Fix OOB handling RX packets in heavy traffic"
>    addition of upstream "mlxbf_gige: fix receive packet race condition"
> The regression will manifest as connectivity problems on "oob_net0" interface
>
> [Fix]
>
> Modify the GIGE driver to include the RX_DMA disable logic in its NAPI poll routine
> This logic was part of "UBUNTU: SAUCE: Fix OOB handling RX packets in heavy traffic"
> but not part of upstream "mlxbf_gige: fix receive packet race condition"
>
> [Test Case]
>
> Boot BF3 platform and ensure oob_net0 interface is up and has IP address
> Bring up many IP interfaces, including oob_net0, and make sure OOB interface
> is continually accessible (e.g. via ping)
>
> [Regression Potential]
>
> Low risk change, adding back in prior logic.
>
> David Thompson (1):
>   UBUNTU: SAUCE: mlxbf_gige: add RX_DMA disable to NAPI poll routine
>
>  drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_rx.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
>



More information about the kernel-team mailing list