NACK: [SRU][M][PATCH 0/2] Dynamically determine acpi_handle_list size

[Thibault Ferrante]

On 22-01-2024 05:26, Ivan Hu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2049733
> 
> [Impact]
> ACPI handle list will be dynamic allocated without default fixed size.
> 
> [Fix]
> Currently the ACPI_MAX_HANDLES is defined fix to 10, and it is not enough for
> some platforms that called ACPI _PSL method to get passive cooling device
> objects. then will get the error message "Invalid passive threshold", this
> patch change the fixed size with the dynamic handle list size which fixes the
> handle reference error.
> 
> [Test Case]
> check the dmesg to see if there is the error message "Invalid passive threshold"
> 
> [Where problems could occur]
> Only change the fixed size with the dynamic handle list size. Risk of regression is low.
> 
> Rafael J. Wysocki (2):
>    ACPI: utils: Dynamically determine acpi_handle_list size
>    ACPI: utils: Fix error path in acpi_evaluate_reference()
> 
>   drivers/acpi/acpi_lpss.c                      | 10 ++-
>   drivers/acpi/scan.c                           |  1 +
>   drivers/acpi/thermal.c                        | 29 ++++++---
>   drivers/acpi/utils.c                          | 63 ++++++++++++++++++-
>   .../platform/surface/surface_acpi_notify.c    | 10 ++-
>   include/acpi/acpi_bus.h                       |  9 ++-
>   6 files changed, 101 insertions(+), 21 deletions(-)
> There is quite a number of changes in `ACPI: utils: Dynamically determine acpi_handle_list size`
commit which deserve at least the mention `backported from` instead of `cherry picked from`.
It would also deserve some explanation of what/why that changes were required.

And when you are reposting an updated patch, adding `v2` to the header and add a
section in the cover letter to explain what changed between these two versions would make things
easier.
--
Thibault