ACK/Cmnt: [SRU][PULL][mantic:linux-gcp] gVNIC DQO-QPL feature

Stefan Bader stefan.bader at canonical.com
Wed Jan 17 08:48:32 UTC 2024


On 12.01.24 20:54, John Cabaj wrote:
> BugLink: https://bugs.launchpad.net/bugs/2040522
> 
> [Impact]
> 
> * Google requested inclusion of gVNIC DQO-QPL feature.
> 
> [Fix]
> 
> * All clean cherry-picks from upstream
> 
> [Test Case]
> 
> * Compile tested
> * Boot tested
> * Tested by Google
> 
> [Where things could go wrong]
> 
> * Low chance of regression. Almost all changes isolated to Google Ethernet drivers.
> * All changes upstream as of v6.6.
> 
> [Other Info]
> 
> * SF #00366697
> 
> --------
> 
> The following changes since commit 674f8904a82ebb8c65e226a8ee694c2836e32897:
> 
>    UBUNTU: Ubuntu-gcp-6.5.0-1011.11 (2024-01-11 10:50:46 -0600)
> 
> are available in the Git repository at:
> 
>    https://git.launchpad.net/~john-cabaj/ubuntu/+source/linux-gcp/+git/mantic-gcp dqo-qpl_feature
> 
> for you to fetch changes up to 00d8a4c9aa963d9eeec3cad5823887bf933e51a2:
> 
>    gve: update gve.rst (2024-01-12 12:53:06 -0600)
> 
> ----------------------------------------------------------------
> Eric Dumazet (1):
>        gve: fix frag_list chaining
> 
> Jakub Kicinski (1):
>        eth: add missing xdp.h includes in drivers
> 
> Jesper Dangaard Brouer (1):
>        gve: trivial spell fix Recive to Receive
> 
> Rushil Gupta (4):
>        gve: Control path for DQO-QPL
>        gve: Tx path for DQO-QPL
>        gve: RX path for DQO-QPL
>        gve: update gve.rst
> 
>   Documentation/networking/device_drivers/ethernet/google/gve.rst |   9 +++
>   drivers/net/bonding/bond_main.c                                 |   1 +
>   drivers/net/ethernet/amazon/ena/ena_netdev.h                    |   1 +
>   drivers/net/ethernet/engleder/tsnep.h                           |   1 +
>   drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.h                |   1 +
>   drivers/net/ethernet/freescale/enetc/enetc.h                    |   1 +
>   drivers/net/ethernet/freescale/fec.h                            |   1 +
>   drivers/net/ethernet/fungible/funeth/funeth_txrx.h              |   1 +
>   drivers/net/ethernet/google/gve/gve.h                           | 113 +++++++++++++++++++++++++++++++--
>   drivers/net/ethernet/google/gve/gve_adminq.c                    |  89 ++++++++++++++++++++++----
>   drivers/net/ethernet/google/gve/gve_adminq.h                    |  10 +++
>   drivers/net/ethernet/google/gve/gve_desc.h                      |   4 +-
>   drivers/net/ethernet/google/gve/gve_main.c                      |  20 ++++--
>   drivers/net/ethernet/google/gve/gve_rx_dqo.c                    | 131 ++++++++++++++++++++++++++++++++------
>   drivers/net/ethernet/google/gve/gve_tx_dqo.c                    | 404 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------
>   drivers/net/ethernet/intel/igc/igc.h                            |   1 +
>   drivers/net/ethernet/microchip/lan966x/lan966x_main.h           |   1 +
>   drivers/net/ethernet/microsoft/mana/mana_en.c                   |   1 +
>   drivers/net/ethernet/stmicro/stmmac/stmmac.h                    |   1 +
>   drivers/net/ethernet/ti/cpsw_priv.h                             |   1 +
>   drivers/net/hyperv/hyperv_net.h                                 |   1 +
>   drivers/net/tap.c                                               |   1 +
>   include/net/mana/mana.h                                         |   2 +
>   23 files changed, 672 insertions(+), 124 deletions(-)
> 
Mostly self-contained. Not sure Patch #2 (eth: add missing xdp.h 
includes in drivers) is really needed as I do not see gve.h dropping the 
netdevice.h inclusion nor netdevice.h dropping xdp.h. But on the other 
side it won't hurt.

Patch #6 is already applied via upstream stable 6.5.4 and would have to 
be skipped.

Acked-by: Stefan Bader <stefan.bader at canonical.com>

- Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240117/710ea0b4/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240117/710ea0b4/attachment-0001.sig>


More information about the kernel-team mailing list