NACK/Cmnt: [SRU][Mantic][Pull] Update mpi3mr driver in mantic

[Stefan Bader]

Rejected for the following reasons (the last one causing the NACK):

On 11.01.24 16:24, Jeff Lane wrote:
> BugLink: https://bugs.launchpad.net/bugs/2045796

Buglink: https://bugs.launchpad.net/bugs/2045233
> 
> Sent originally on 12/14/2023 so sending it again for review.

You sent your update in reply to the older submission which is now 
invalidated (by NACK).

> 
> This update has been initiated to incorporate the mpi3mr driver from upstream
> into the upcoming Ubuntu releases (Ubuntu 22.04.x point releases).
> 
> This has been requested by both Broadcom as the upstream and by one of the
> larger OEM partners who are going to be selling systems with these storage
> controllers to customers. This series of patches includes bug fixes and support
> for current Broadcom controllers.
> 
> This is needed in 22.04.4 in the installer environment to ensure users are able
> to install Ubuntu to servers containing these storage controllers.
> 
> The following changes since commit 92068b6625871785b6e22db81943445470f5bebc:
> 
> 
>    ASoC: Intel: soc-acpi: rt713+rt1316, no sdw-dmic config (2023-12-01 15:43:16 +0100)
> 
> are available in the Git repository at:
> 
>    https://git.launchpad.net/~bladernr/ubuntu/+source/linux/+git/mantic 2045233-mpi3mr-for-22.04.4
> 
> for you to fetch changes up to efa63ec28f2fd49944304b9b5f0dce05cb5927df:

FETCH_HEAD changes, this now has to be up to 
db9f1335c959d172dad1a3653b3b8e96e1916554

> 
>    scsi: mpi3mr: Update driver version to 8.5.1.0.0 (2023-12-12 09:33:22 -0500)
> 
> ----------------------------------------------------------------
> Chandrakanth patil (8):
>        scsi: mpi3mr: Refresh sdev queue depth after controller reset
>        scsi: mpi3mr: Clean up block devices post controller reset
>        scsi: mpi3mr: Block PEL Enable Command on Controller Reset and Unrecoverable State
>        scsi: mpi3mr: Fetch correct device dev handle for status reply descriptor
>        scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-1
>        scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-2
>        scsi: mpi3mr: Support for preallocation of SGL BSG data buffers part-3
>        scsi: mpi3mr: Update driver version to 8.5.1.0.0
> 
> Hannes Reinecke (1):
>        scsi: mpi3mr: Split off bus_reset function from host_reset
> 
> Ranjan Kumar (6):
>        scsi: mpi3mr: Invoke soft reset upon TSU or event ack time out
>        scsi: mpi3mr: Update MPI Headers to version 3.00.28
>        scsi: mpi3mr: Add support for more than 1MB I/O
>        scsi: mpi3mr: WRITE SAME implementation
>        scsi: mpi3mr: Enhance handling of devices removed after controller reset
>        scsi: mpi3mr: Update driver version to 8.5.0.0.0
> 
> Sumit Saxena (5):
>        scsi: mpi3mr: Add support for SAS5116 PCI IDs
>        scsi: mpi3mr: Add PCI checks where SAS5116 diverges from SAS4116
>        scsi: mpi3mr: Increase maximum number of PHYs to 64 from 32
>        scsi: mpi3mr: Add support for status reply descriptor
>        scsi: mpi3mr: driver version upgrade to 8.5.0.0.50
> 
>   drivers/scsi/mpi3mr/mpi/mpi30_cnfg.h      |   2 +-
>   drivers/scsi/mpi3mr/mpi/mpi30_ioc.h       |   2 +
>   drivers/scsi/mpi3mr/mpi/mpi30_transport.h |   2 +-
>   drivers/scsi/mpi3mr/mpi3mr.h              |  52 ++-
>   drivers/scsi/mpi3mr/mpi3mr_app.c          | 536 ++++++++++++++++++++++++------
>   drivers/scsi/mpi3mr/mpi3mr_fw.c           | 155 ++++++++-
>   drivers/scsi/mpi3mr/mpi3mr_os.c           | 241 +++++++++++---
>   drivers/scsi/mpi3mr/mpi3mr_transport.c    |  16 +-
>   include/uapi/scsi/scsi_bsg_mpi3mr.h       |   2 +
>   9 files changed, 820 insertions(+), 188 deletions(-)
> 
On the positive side, the set is limited to mpi3mr subdriver and the set 
applies cleanly.
But patches #13 ... #20 have "BugLink BugLink: http..." instead of 
"BugLink: http...".

-- 
- Stefan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240117/31ef22bb/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240117/31ef22bb/attachment-0001.sig>