NACK[N]/Cmnt: [PATCH 0/1][SRU][M][N] drm: Update file owner during use

[Stefan Bader]

On 27.12.23 02:28, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2047461
> 
> [Impact]
> Our testing tools need to check the app runs on which GPU, and now it only
> shows the processes as Xorg or XWayland
> 
>      $ cat /sys/kernel/debug/dri/0/clients
>                   command pid dev master a uid magic
>                      Xorg 2344 0 y y 0 0
>                      Xorg 2344 0 n y 0 2
>                      Xorg 2344 0 n y 0 3
>                      Xorg 2344 0 n y 0 4
> 
> [Fix]
> The commit from v6.7-rc1 fixes the issue
> 
>      $ cat /sys/kernel/debug/dri/0/clients
>                   command tgid dev master a uid magic
>                      Xorg 830 0 y y 0 0
>             xfce4-session 880 0 n y 0 1
>                     xfwm4 943 0 n y 0 2
>                 neverball 1095 0 n y 0 3
> 
> [Test case]
> 1. check processes by 'cat /sys/kernel/debug/dri/0/clients'
> 2. runs glxgears(specify the GPU if needed)
> 3. check the precesses again and there should be a 'glxgears' process
> 
> [Where problems could occur]
> This commit added some protections on read/write and only changes the
> process' pid, the worst case is that the process got the wrong pid as its
> owner.
> 
> Tvrtko Ursulin (1):
>    drm: Update file owner during use
> 
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c |  6 ++--
>   drivers/gpu/drm/drm_auth.c              |  3 +-
>   drivers/gpu/drm/drm_debugfs.c           | 10 ++++---
>   drivers/gpu/drm/drm_file.c              | 40 +++++++++++++++++++++++--
>   drivers/gpu/drm/drm_ioctl.c             |  3 ++
>   drivers/gpu/drm/nouveau/nouveau_drm.c   |  5 +++-
>   drivers/gpu/drm/vmwgfx/vmwgfx_gem.c     |  6 ++--
>   include/drm/drm_file.h                  | 13 ++++++--
>   8 files changed, 71 insertions(+), 15 deletions(-)
> 

Rejected for the following reasons:
- Already included in Noble after 6.7 transition.

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240112/c2e5e60f/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240112/c2e5e60f/attachment-0001.sig>