ACK/Cmnt: [PATCH 0/2][SRU][J] Add ODM driver rtc-pcf85263

[Stefan Bader]

On 28.12.23 04:18, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/2045385
> 
> [ Impact ]
> rtc-pcf85263 driver is needed for ODM partner
> 
> [ Test Plan ]
> Load the driver setting the timestamp level to 0 (default to 1) :
> modprobe rtc-pcf85263 tsl=0
> 
> export the rtc device:
> echo "pcf85263 0x51" > /sys/bus/i2c/devices/i2c-1/new_device
> 
> RTC device should act as a standard RTC,
> hwclock -r -f /dev/rtc1 #for reading
> hwclock -w -f /dev/rtc1 #for writing
> 
> This driver has anti-tampering function.
> Get the current tamper timestamp:
> cat /sys/class/rtc/rtc1/device/timestamp1
> 
> unmount the bottom metal panel, unscrewing the 6x T-10 screws and let the anti-tampering goes in open state.
> The timestamp should be updated to the current time.
> 
> [ Where problems could occur ]
> Events could occur on the I2C bus communication.
> 
> Chia-Lin Kao (AceLan) (1):
>    UBUNTU: [Config] updateconfigs for ODM drivers CONFIG_RTC_DRV_PCF85263
> 
> Filippo Copetti (1):
>    UBUNTU: SAUCE: ODM: rtc: add PCF85263 RTC driver
> 
>   MAINTAINERS                      |    6 +
>   debian.master/config/annotations |    1 +
>   drivers/rtc/Kconfig              |   10 +
>   drivers/rtc/Makefile             |    1 +
>   drivers/rtc/rtc-pcf85263.c       | 1784 ++++++++++++++++++++++++++++++
>   drivers/rtc/rtc-pcf85263.h       |  387 +++++++
>   6 files changed, 2189 insertions(+)
>   create mode 100644 drivers/rtc/rtc-pcf85263.c
>   create mode 100644 drivers/rtc/rtc-pcf85263.h
> 
So this adds a completely new driver we are contractually obliged to 
support. And the target is a server install which makes the GA kernel 
the right place. Still not sure whether it would not be better to also 
have these things also in the hwe backports. But that needs a bit more 
thinking as we probably want a method which activates things only when 
building in previous LTS. For now ...

Acked-by: Stefan Bader <stefan.bader at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240109/cb1b0baa/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240109/cb1b0baa/attachment-0001.sig>