ACK: [F][SRU][PATCH 0/1] selftests: Skip TM tests on synthetic TM implementations

[Roxana Nicolescu]

On 21/12/2023 11:26, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/2032641
>
> [Impact]
> The powerpc tests from kernel selftests were unable to finish properly
> on Power10 VM with Focal 5.4 kernel. There will be lots of failures for
> powerpc/ptrace and powerpc/tm tests. For example the ptrace-tm-gpr:
>    # selftests: powerpc/ptrace: ptrace-tm-gpr
>    # test: ptrace_tm_gpr
>    # tags: git_version:unknown
>    # [FAIL] Test FAILED on line 94
>    # GPR[14]: 1 Expected: 2
>    # GPR[15]: 1 Expected: 2
>    # GPR[16]: 1 Expected: 2
>    # GPR[17]: 1 Expected: 2
>    # GPR[18]: 1 Expected: 2
>    # GPR[19]: 1 Expected: 2
>    # GPR[20]: 1 Expected: 2
>    # GPR[21]: 1 Expected: 2
>    # GPR[22]: 1 Expected: 2
>    # GPR[23]: 1 Expected: 2
>    # GPR[24]: 1 Expected: 2
>    # GPR[25]: 1 Expected: 2
>    # GPR[26]: 1 Expected: 2
>    # GPR[27]: 1 Expected: 2
>    # GPR[28]: 1 Expected: 2
>    # GPR[29]: 1 Expected: 2
>    # GPR[30]: 1 Expected: 2
>    # GPR[31]: 1 Expected: 2
>    # failure: ptrace_tm_gpr
>    not ok 1 selftests: powerpc/ptrace: ptrace-tm-gpr # exit=1
>
> [Fix]
> * 031fd80f87 selftests: Skip TM tests on synthetic TM implementations
>
> This patch has already landed on Jammy+. Only Focal will need this
> patch. And it needs to be backported to skip changes on the
> tm-signal-pagefault.c test, which does not exist on Focal tree.
>
> [Test Plan]
> Run the patched powerpc tests from kernel selftests:
>    $ sudo make TARGETS=powerpc run_tests
>
> Previously failing powerpc/ptrace and powerpc/tm tests will be skipped.
> For example the ptrace-tm-gpr test:
>    # selftests: powerpc/ptrace: ptrace-tm-gpr
>    # test: ptrace_tm_gpr
>    # tags: git_version:b315960-dirty
>    # [SKIP] Test skipped on line 116
>    # skip: ptrace_tm_gpr
>    ok 2 selftests: powerpc/ptrace: ptrace-tm-gpr
>
> [Where problems could occur]
> Change limited to testing tools, and it's just skipping unsuitable
> tests for specific architecture, no impact to real kernel functions.
>
> Jordan Niethe (1):
>    selftests: Skip TM tests on synthetic TM implementations
>
>   .../selftests/powerpc/ptrace/ptrace-tm-gpr.c       |  1 +
>   .../selftests/powerpc/ptrace/ptrace-tm-spd-gpr.c   |  1 +
>   .../selftests/powerpc/ptrace/ptrace-tm-spd-tar.c   |  1 +
>   .../selftests/powerpc/ptrace/ptrace-tm-spd-vsx.c   |  1 +
>   .../selftests/powerpc/ptrace/ptrace-tm-spr.c       |  1 +
>   .../selftests/powerpc/ptrace/ptrace-tm-tar.c       |  1 +
>   .../selftests/powerpc/ptrace/ptrace-tm-vsx.c       |  1 +
>   tools/testing/selftests/powerpc/signal/signal_tm.c |  1 +
>   tools/testing/selftests/powerpc/tm/tm-exec.c       |  1 +
>   tools/testing/selftests/powerpc/tm/tm-fork.c       |  1 +
>   tools/testing/selftests/powerpc/tm/tm-poison.c     |  1 +
>   .../testing/selftests/powerpc/tm/tm-resched-dscr.c |  1 +
>   .../powerpc/tm/tm-signal-context-chk-fpu.c         |  1 +
>   .../powerpc/tm/tm-signal-context-chk-gpr.c         |  1 +
>   .../powerpc/tm/tm-signal-context-chk-vmx.c         |  1 +
>   .../powerpc/tm/tm-signal-context-chk-vsx.c         |  1 +
>   .../selftests/powerpc/tm/tm-signal-sigreturn-nt.c  |  1 +
>   .../testing/selftests/powerpc/tm/tm-signal-stack.c |  1 +
>   tools/testing/selftests/powerpc/tm/tm-sigreturn.c  |  1 +
>   tools/testing/selftests/powerpc/tm/tm-syscall.c    |  2 +-
>   tools/testing/selftests/powerpc/tm/tm-tar.c        |  1 +
>   tools/testing/selftests/powerpc/tm/tm-tmspr.c      |  1 +
>   tools/testing/selftests/powerpc/tm/tm-trap.c       |  1 +
>   .../testing/selftests/powerpc/tm/tm-unavailable.c  |  1 +
>   .../testing/selftests/powerpc/tm/tm-vmx-unavail.c  |  1 +
>   tools/testing/selftests/powerpc/tm/tm-vmxcopy.c    |  1 +
>   tools/testing/selftests/powerpc/tm/tm.h            | 36 ++++++++++++++++++++++
>   27 files changed, 62 insertions(+), 1 deletion(-)
>
Acked-by: Roxana Nicolescu <roxana.nicolescu at canonical.com>