ACK/Cmnt: [jammy xilinx-zynqmp 0/1] Fix backported kria device tree changes

Manuel Diewald manuel.diewald at canonical.com
Tue Feb 20 18:39:00 UTC 2024


On Tue, Feb 20, 2024 at 02:30:58PM +1000, Portia Stephens wrote:
> [ Impact ]
> 
> * Kria device tree's were backported from Xilinx's 6.1 tree in order to add
> support for the KD240 platform
> (https://bugs.launchpad.net/ubuntu/+source/linux-xilinx-zynqmp/+bug/2046280) .
> * Testing had previously been done a development branch with non-upstreamable
> patches. 3 issues were introduced to the KD240 image that was not present on
> the development branch.
> * Since all Xilinx device tree's are so interdependent all Kria and ZCU device
> trees were updated including certified platforms.
> 
> [ Test Plan ]
> 
> * QA will run certification testing on the KD240 platform
> * Normal certification testing will be run on all other certified platforms
> 
> [ Where problems could occur ]
> 
> * This impacts the device tree for certified Xilinx platforms which could break
> any of the device touched by the change.
> 
> [ Other Info ]
> 
> * Buglink: https://bugs.launchpad.net/ubuntu/+source/linux-xilinx-zynqmp/+bug/2054366
> 
> * Private launchpad bugs that contain the regressions failure:
> https://bugs.launchpad.net/limerick/+bug/2051228
> https://bugs.launchpad.net/limerick/+bug/2051224
> https://bugs.launchpad.net/limerick/+bug/2051201
> 
> Portia Stephens (1):
>   UBUNTU: SAUCE: zynqmp.dtsi fix incorrectly backported changes
> 
>  .../arm64/boot/dts/xilinx/zynqmp-clk-ccf.dtsi |  2 +-
>  arch/arm64/boot/dts/xilinx/zynqmp.dtsi        | 42 +++++++++++--------
>  2 files changed, 25 insertions(+), 19 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

The Launchpad bug should target series 'Jammy'. A brief [Fix] section
could also be helpful, to give some context to the changes maybe. Either
way, LGTM.

Acked-by: Manuel Diewald <manuel.diewald at canonical.com>

-- 
 Manuel



More information about the kernel-team mailing list