ACK/Cmnt: [SRU j/linux-raspi PATCH v2 0/2] Make snapcraft.yaml work

[Manuel Diewald]

On Mon, Feb 19, 2024 at 05:37:03PM +0900, Masahiro Yamada wrote:
> linux-raspi added snapcraft.yaml more than a decade ago,
> which is not functional at all.
> 
> Remove the old one, and re-implement working snapcraft.yaml.
> 
> BugLink: https://bugs.launchpad.net/bugs/2051468
> 
> SRU Justification:
> 
> Impact:
> 
>   The in-tree snapcraft.yaml is stale. It does not produce any functional kernel
>   snap for jammy:linux-raspi.
> 
> Fix:
>   Replace the stale snapcraft.yaml with a newly implemented one.
> 
> Testcase:
> 
>    Build a pi-kernel with the following command:
> 
>    [for arm64]
> 
>     $ snapcraft --use-lxd --build-for=arm64
> 
>    [for armhf]
> 
>     $ snapcraft --use-lxd --build-for=armhf
> 
>    Then, install it to Ubuntu Core 22 running on a raspi board.
> 
>     $ snap install --dangerous <kernel-snap>
> 
>    Please note you need "grade: dangerous" for replacing
>    the kernel using the local snap.
> 
> 
> 
> Masahiro Yamada (2):
>   UBUNTU: [Packaging] Remove old snapcraft.yaml
>   UBUNTU: [Packaging] Add snapcraft.yaml for building uc22 pi-kernel
>     snap
> 
>  snapcraft.yaml | 175 ++++++++++++++++++++++++++++++++++++++++---------
>  1 file changed, 145 insertions(+), 30 deletions(-)
> 
> -- 
> 2.40.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Please add 'Jammy' as the target series in the LP bug by using the
'Target to series' button.

Acked-by: Manuel Diewald <manuel.diewald at canonical.com>

-- 
 Manuel