NACK/Cmnt: [SRU][N/O/unstable][PATCH 0/2] Enable ASPM for nvme controller when working in RAID on mode

[Stefan Bader]

On 15.08.24 05:22, Hui Wang wrote:
> BugLink: https://bugs.launchpad.net/bugs/2072679
> 
> [Impact]
> The NVME controller works in RAID on mode by default on some Dell
> machines, and in this case, the PCIE ASPM couldn't be enabled, and
> as a result the system idle can't enter deep idle states. This issue
> not only impacts ubuntu users but also impacts our Dell OEM projects.
> 
> 
> [Fix]
> pick 2 commits from linux-pci mailist
> 
> [Test]
> After running the patched kernel, we could run 'sudo lspci -nnvv'
> and check "Non-Volatile memory controller":
>                 LnkCtl: ASPM L1 Enabled;
> 
> And check idle states, we could see the system could enter deep idle:
> $ sudo cat /sys/kernel/debug/pmc_core/package_cstate_show
> Package C2 : 55740989
> Package C3 : 4656373
> Package C6 : 43325041
> Package C7 : 6687655
> Package C8 : 44948950
> Package C9 : 1693
> Package C10 : 92865596
> 
> [Where problems could occur]
> Because the patchset is not accepted by upstream yet, it is a bit
> risky to merge the patchset to ubuntu kernel. And the patch only
> impacts vmd driver, hence if there is regression, it could only be
> in the nvme driver with RAID on mode. The regression possibility is
> very low because we already tested the patch on many Dell, lenovo
> machines, there is no regression so far.
> 
> 
> Kai-Heng Feng (2):
>    UBUNTU: SAUCE: PCI: ASPM: Allow OS to configure ASPM where BIOS is
>      incapable of
>    UBUNTU: SAUCE: PCI: vmd: Let OS control ASPM for devices under VMD
>      domain
> 
>   drivers/pci/controller/vmd.c | 2 ++
>   drivers/pci/pcie/aspm.c      | 8 ++++++--
>   include/linux/pci.h          | 1 +
>   3 files changed, 9 insertions(+), 2 deletions(-)
> 

Rejected for the following reasons:
- Patches which are not at least in linux-next are not material for SRU

-Stefan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240815/e647b5c5/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240815/e647b5c5/attachment-0001.sig>