NAK/Cmnt: [SRU][J:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: mlxbf-gige: autonegotiation fails to complete on BF2

[Asmaa Mnebhi]

Thanks Bartlomiej! Sent patch v2

> -----Original Message-----
> From: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com>
> Sent: Tuesday, April 30, 2024 6:10 AM
> To: Asmaa Mnebhi <asmaa at nvidia.com>
> Cc: Ubuntu Kernel Team <kernel-team at lists.ubuntu.com>
> Subject: NAK/Cmnt: [SRU][J:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE:
> mlxbf-gige: autonegotiation fails to complete on BF2
> 
> Hi Asmaa,
> 
> This patch fails to build:
> 
> /build/jammy/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.
> c: In func tion 'mlxbf_gige_open':
> /build/jammy/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.
> c:158:33:
> error: 'MLXBF_GIGE_BLUEFIELD2' undeclared (first use in this function)
>   158 |         if (priv->hw_version == MLXBF_GIGE_BLUEFIELD2) {
>       |                                 ^~~~~~~~~~~~~~~~~~~~~
> 
> --
> Best regards,
> Bartlomiej
> 
> On Thu, Apr 18, 2024 at 5:26 PM Asmaa Mnebhi <asmaa at nvidia.com>
> wrote:
> >
> > BugLink:
> >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs
> >
> .launchpad.net%2Fbugs%2F2062384&data=05%7C02%7Casmaa%40nvidia.co
> m%7C94
> >
> 8f321eb10043cda3b608dc68fdc1a5%7C43083d15727340c1b7db39efd9ccc17
> a%7C0%
> >
> 7C0%7C638500686316907362%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
> wLjAwMDAiL
> >
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C0%7C%7C%7C&sdata
> =Q4%2F
> > 5qfvFmL9nH3BNSlc0zX2Uymh4mPiMUByUEqq4Hdc%3D&reserved=0
> >
> > SRU Justification:
> >
> > [Impact]
> >
> > During the reboot test, QA found an intermittent issue where the OOB link
> is down.
> > The link is down because the KSZ9031 PHY fails to complete
> autonegotiation.
> > Even under "normal" circumstances where autonegotiation completes, it
> > takes an abnormal time to do so (on average, at least 8 seconds).
> >
> > Hence, the hardware team and Microchip are involved in this debug but
> the root cause is still unknown.
> > In the meantime, we need to provide a software workaround since
> customers are starting to see this issue as well.
> >
> > [Fix]
> >
> > * Restart autonegotiation when it fails the first time.
> >
> > [Test Case]
> >
> > * On BF2, Do the reboot test: 2000 loops.
> > * Check that the OOB link is up and ip is assigned.
> >
> > [Regression Potential]
> >
> > * no known regression.
> >
> > [Other]
> > * Note that this issue is BF2 hardware specific. The same ethernet code is
> used for BF3 and we don't see any issues. In fact, the link up time on BF3 <=
> 1s. On BF2, the link up time is > 8s.
> > * we have been aware of this issue for 2 years and have shared this with
> the PHY vendor and the hardware team but there were not root causes
> identified.
> >