ACK/Cmnt: [PATCH 0/7][Noble] Fix after-suspend-mediacard/sdhc-insert test failed

[Stefan Bader]

On 11.04.24 03:32, AceLan Kao wrote:
> From: "Chia-Lin Kao (AceLan)" <acelan.kao at canonical.com>
> 
> BugLink:https://bugs.launchpad.net/bugs/2042500
> 
> [Impact]
> checkbox test case, after-suspend-mediacard/sdhc-insert, failed.
> 
> [Fix]
> The new series of the fix has been merged into v6.9
> 
> 6d4266675279 PCI/ASPM: Update save_state when configuration changes
> 64dbb2d70744 PCI/ASPM: Disable L1 before configuring L1 Substates
> c198fafa0125 PCI/ASPM: Call pci_save_ltr_state() from pci_save_pcie_state()
> 17423360a27a PCI/ASPM: Save L1 PM Substates Capability for suspend/resume
> 1e11b5494c3d PCI/ASPM: Move pci_save_ltr_state() to aspm.c
> f3994bba8200 PCI/ASPM: Always build aspm.c
> fa84f4435a62 PCI/ASPM: Move pci_configure_ltr() to aspm.c
> 
> [Test Case]
> 1. suspend and resume.
> 2. check if the error appears in dmesg
> ~~~
>   pcieport 0000:00:1c.0: pciehp: Slot(5): Card not present
>   rtsx_pci 0000:05:00.0: Unable to change power state from D0 to D3hot, device inaccessible
>   rtsx_pci 0000:05:00.0: Unable to change power state from D3cold to D0, device inaccessible
> ~~~
> 
> [Where the problems could occur]
> Hard to evaluate, these patches change the PCI/ASPM behavior and may lead to PCI devices work abnormal.
> 
> Bjorn Helgaas (1):
>    PCI/ASPM: Disable L1 before configuring L1 Substates
> 
> David E. Box (5):
>    PCI/ASPM: Move pci_configure_ltr() to aspm.c
>    PCI/ASPM: Always build aspm.c
>    PCI/ASPM: Move pci_save_ltr_state() to aspm.c
>    PCI/ASPM: Save L1 PM Substates Capability for suspend/resume
>    PCI/ASPM: Call pci_save_ltr_state() from pci_save_pcie_state()
> 
> Vidya Sagar (1):
>    PCI/ASPM: Update save_state when configuration changes
> 
>   drivers/pci/pci.c         |  75 ++---------
>   drivers/pci/pci.h         |  13 +-
>   drivers/pci/pcie/Makefile |   2 +-
>   drivers/pci/pcie/aspm.c   | 268 +++++++++++++++++++++++++++++++++++++-
>   drivers/pci/probe.c       |  62 +--------
>   include/linux/pci.h       |   2 +-
>   6 files changed, 292 insertions(+), 130 deletions(-)
> 
I am a bit torn here, it seems to be a lot of delta just to fix 
suspend-resume. On the other hand it is something that probably gets hit 
a lot...

Acked-by: Stefan Bader <stefan.bader at canonical.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE8675DEECBEECEA3.asc
Type: application/pgp-keys
Size: 48643 bytes
Desc: OpenPGP public key
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240424/f969972b/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240424/f969972b/attachment-0001.sig>