NACK: [Unstable/Noble][PATCH v1 0/2] UBUNTU: SAUCE: pid_namespace: namespacify sysctl kernel.pid_max

[Roxana Nicolescu]

On 18/04/2024 15:33, Alexander Mikhalitsyn wrote:
> Dear friends,
>
> this is a proposal to take this upstream patch series:
> https://lore.kernel.org/all/20240222160915.315255-1-aleksandr.mikhalitsyn@canonical.com/#t
> as a Ubuntu Sauce.
>
> I have a plan to make it in upstream Linux kernel. But we have internal
> requestors in Canonical for this functionallity and I believe
> that it makes sense to take it as Ubuntu Sauce for now.
>
> Signed-off-by: Alexander Mikhalitsyn <aleksandr.mikhalitsyn at canonical.com>
>
> Christian Brauner (2):
>    pid: allow pid_max to be set per pid namespace
>    tests/pid_namespace: add pid_max tests
>
>   include/linux/pid.h                           |   3 -
>   include/linux/pid_namespace.h                 |  10 +-
>   kernel/pid.c                                  | 126 +++++-
>   kernel/pid_namespace.c                        |  43 ++-
>   kernel/sysctl.c                               |   9 -
>   kernel/trace/pid_list.c                       |   2 +-
>   kernel/trace/trace.c                          |   2 +-
>   kernel/trace/trace.h                          |   2 -
>   .../selftests/pid_namespace/.gitignore        |   1 +
>   .../testing/selftests/pid_namespace/Makefile  |   2 +-
>   .../testing/selftests/pid_namespace/pid_max.c | 358 ++++++++++++++++++
>   11 files changed, 522 insertions(+), 36 deletions(-)
>   create mode 100644 tools/testing/selftests/pid_namespace/pid_max.c
A buglink would help to understand the reason behind this. I don't 
understand why we have to do include this before upstream accepts.


Roxana