NACK/Cmnt[N]: [RFC][U/N][PATCH 0/1] UBUNTU: [Packaging] Don't package tools_host when tools_common is disabled

Andrea Righi andrea.righi at canonical.com
Thu Apr 11 15:22:04 UTC 2024


On Wed, Apr 03, 2024 at 03:58:29PM +0200, Thibault Ferrante wrote:
> Current packaging rules fails if do_tools_common=false and do_tools_host=true but
> in a non clear manner.
> I'm not sure how we want to move forward with this, do we want the build to break explicitely
> or change the build rules to support this use case ?
> 
> The patch is there just to highlight the breaking sections.

The patch itself seems to make sense to me, but we are a little bit too
close to the release date (today is kernel freeze), applying a packaging
change like this seems harmful, but such changes may have unexpected
consequences...

Therefore I'm NACK-ing this for noble for now. But I'm totally fine to
apply (and test) this in linux-unstable. I think this is a safer plan.
What do you think?

Thanks
-Andrea

> 
> Thibault Ferrante (1):
>   UBUNTU: [Packaging] Don't package tools_host when tools_common is
>     disabled
> 
>  debian/rules.d/3-binary-indep.mk | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> -- 
> 2.43.0
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team



More information about the kernel-team mailing list