ACK: [SRU] [J/M/N] [PATCH 0/1] Avoid creating non-working backlight sysfs knob from ASUS board

Manuel Diewald manuel.diewald at canonical.com
Mon Apr 8 08:48:06 UTC 2024


On Mon, Apr 08, 2024 at 11:33:09AM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/2060422
> 
> [Impact]
> Backlight sysfs knobs created by asus-wmi don't really work, hence
> systemd-backlight services are in failed state.
> 
> [Fix]
> Ensure the backlight device are really present
> 
> [Test]
> With the fix applied, the backlight sysfs knobs are not longer present
> under /sys/class/backlight, so there's no more failed systemd-backlight
> service.
> 
> [Where problems could occur]
> Though highly unlikely, but if there's working device that is created
> even when the WMI read is 0xffffffff, the device will be missing.
> 
> Kai-Heng Feng (1):
>   platform/x86: asus-wmi: Consider device is absent when the read is ~0
> 
>  drivers/platform/x86/asus-wmi.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team at lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Manuel Diewald <manuel.diewald at canonical.com>

-- 
 Manuel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.ubuntu.com/archives/kernel-team/attachments/20240408/b63d7697/attachment.sig>


More information about the kernel-team mailing list