ACK/Cmnt: [SRU][J:linux-bluefield][PATCH v1 0/1] mlxbf_gige: stop interface during shutdown
Jose Ogando
jose.ogando at canonical.com
Wed Apr 3 15:05:17 UTC 2024
Acked-by: Jose Ogando <jose.ogando at canonical.com>
Similar comment, specify that this comes from linux-next.
On Wed, 2024-04-03 at 14:57 +0200, Bartlomiej Zolnierkiewicz wrote:
> Acked-by: Bartlomiej Zolnierkiewicz
> <bartlomiej.zolnierkiewicz at canonical.com>
>
> This commit is cherry-picked from the linux-next tree which should be
> mentioned in the cherry-pick line. However this can be fixed while
> applying.
>
> On Tue, Apr 2, 2024 at 4:15 PM David Thompson
> <davthompson at nvidia.com> wrote:
> >
> > BugLink: https://bugs.launchpad.net/bugs/2059951
> >
> > SRU Justification:
> >
> > [Impact]
> > The mlxbf_gige driver shutdown() is invoked during reboot
> > processing, but the stop() logic is not guaranteed to execute
> > on all distros. If stop() does not execute NAPI remains enabled
> > during system shutdown and can cause an exception if NAPI is
> > scheduled when interface is shutdown but not stopped.
> >
> > [Fix]
> > The networking interface managed by the mlxbf_gige driver must
> > be stopped during reboot processing so that it is put into a
> > clean state and driver callbacks won't be called.
> >
> > [Test Case]
> > * Put BF platform into a reboot loop
> > * Ensure that BF platform brings up "oob_net0" interface each
> > reboot,
> > and that no mlxbf_gige driver exceptions occur
> >
> > [Regression Potential]
> > There is low potential for regression as this brings in upstream
> > content.
> >
> > [Other]
> > None
> >
> > David Thompson (1):
> > mlxbf_gige: stop interface during shutdown
> >
> > .../net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 10
> > ++++++++--
> > 1 file changed, 8 insertions(+), 2 deletions(-)
> >
>
More information about the kernel-team
mailing list