ACK: [SRU][F:linux-bluefield][PATCH v2 0/1] UBUNTU: SAUCE: mlxbf-gige: Enable the OOB port in mlxbf_gige_open

[Bartlomiej Zolnierkiewicz]

Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com>

(reply to the correct mail this time)

On Wed, Sep 20, 2023 at 7:39 PM Asmaa Mnebhi <asmaa at nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2035128
>
> SRU Justification:
>
> [Impact]
>
> At the moment, the OOB port is enabled in the mlxbf_gige_probe function. If the mlxbf_gige_open is not executed, this could cause pause frames to increase in the case where there is high backgroud traffic. This results in clogging the BMC port as well.
>
> [Fix]
>
> * Move enabling the OOB port to mlxbf_gige_open.
>
> [Test Case]
>
> * Main test for this bug: Check that the BMC is always pingable while pushing a BFB
>
> Other tests:
> * Check if the gige driver is loaded
> * Check that the oob_net0 interface is up and operational
> * Do the reboot test and powercycle test and check the oob_net0 interface again
> * Push BFB multiple times and make sure the OOB is up and running
>
> [Regression Potential]
>
> Since are moving code that hasn't moved since BF2, it is important to make sure that there is no regression.
> Make sure that the OOB interface is always up and pingable after the reboot test, the powercycle test and after pushing a BFB.
>