NAK: [SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE: mlxbf-gige: Enable the OOB port in mlxbf_gige_open

[Asmaa Mnebhi]

Apologies. Will send a patch right away

> -----Original Message-----
> From: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz at canonical.com>
> Sent: Wednesday, September 20, 2023 12:12 PM
> To: Asmaa Mnebhi <asmaa at nvidia.com>
> Cc: Ubuntu Kernel Team <kernel-team at lists.ubuntu.com>
> Subject: NAK: [SRU][F:linux-bluefield][PATCH v1 0/1] UBUNTU: SAUCE:
> mlxbf-gige: Enable the OOB port in mlxbf_gige_open
> 
> Hi Asmaa,
> 
> This patch fails to build:
> 
> /build/focal/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:
> In function 'mlxbf_gige_open':
> /build/focal/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:
> 146:18:
> error: 'base' undeclared (first use in this function)
>   146 |  control = readq(base + MLXBF_GIGE_CONTROL);
>       |                  ^~~~
> /build/focal/include/uapi/linux/byteorder/little_endian.h:32:51: note:
> in definition of macro '__le64_to_cpu'
>    32 | #define __le64_to_cpu(x) ((__force __u64)(__le64)(x))
>       |                                                   ^
> /build/focal/arch/arm64/include/asm/io.h:137:32: note: in expansion of
> macro 'readq_relaxed'
>   137 | #define readq(c)  ({ u64 __v = readq_relaxed(c); __iormb(__v); __v; })
>       |                                ^~~~~~~~~~~~~
> /build/focal/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:
> 146:12:
> note: in expansion of macro 'readq'
>   146 |  control = readq(base + MLXBF_GIGE_CONTROL);
>       |            ^~~~~
> /build/focal/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:
> 146:18:
> note: each undeclared identifier is reported only once for each function it
> appears in
>   146 |  control = readq(base + MLXBF_GIGE_CONTROL);
>       |                  ^~~~
> /build/focal/include/uapi/linux/byteorder/little_endian.h:32:51: note:
> in definition of macro '__le64_to_cpu'
>    32 | #define __le64_to_cpu(x) ((__force __u64)(__le64)(x))
>       |                                                   ^
> /build/focal/arch/arm64/include/asm/io.h:137:32: note: in expansion of
> macro 'readq_relaxed'
>   137 | #define readq(c)  ({ u64 __v = readq_relaxed(c); __iormb(__v); __v; })
>       |                                ^~~~~~~~~~~~~
> /build/focal/drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:
> 146:12:
> note: in expansion of macro 'readq'
>   146 |  control = readq(base + MLXBF_GIGE_CONTROL);
>       |            ^~~~~
> make[7]: *** [/build/focal/scripts/Makefile.build:270:
> drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.o] Error 1
> make[7]: *** Waiting for unfinished jobs....
> 
> (probably 'priv->base' should be used instead of 'base')
> 
> --
> Best regards,
> Bartlomiej
> 
> On Tue, Sep 19, 2023 at 11:27 PM Asmaa Mnebhi <asmaa at nvidia.com>
> wrote:
> >
> > BugLink:
> >
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs
> >
> .launchpad.net%2Fbugs%2F2035128&data=05%7C01%7Casmaa%40nvidia.c
> om%7C7f
> >
> aa66efff144bfda03308dbb9f4635d%7C43083d15727340c1b7db39efd9ccc17a
> %7C0%
> >
> 7C0%7C638308231522056065%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
> wLjAwMDAiL
> >
> CJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&s
> data=8B
> > 2cHYBXTu59vzrGsTqwTc08pZyztwfZntQ5Rdcq9zw%3D&reserved=0
> >
> > SRU Justification:
> >
> > [Impact]
> >
> > At the moment, the OOB port is enabled in the mlxbf_gige_probe function.
> If the mlxbf_gige_open is not executed, this could cause pause frames to
> increase in the case where there is high backgroud traffic. This results in
> clogging the BMC port as well.
> >
> > [Fix]
> >
> > * Move enabling the OOB port to mlxbf_gige_open.
> >
> > [Test Case]
> >
> > * Main test for this bug: Check that the BMC is always pingable while
> > pushing a BFB
> >
> > Other tests:
> > * Check if the gige driver is loaded
> > * Check that the oob_net0 interface is up and operational
> > * Do the reboot test and powercycle test and check the oob_net0
> > interface again
> > * Push BFB multiple times and make sure the OOB is up and running
> >
> > [Regression Potential]
> >
> > Since are moving code that hasn't moved since BF2, it is important to
> make sure that there is no regression.
> > Make sure that the OOB interface is always up and pingable after the
> reboot test, the powercycle test and after pushing a BFB.
> >